This repository was archived by the owner on Jul 25, 2019. It is now read-only.
Add long long and unsigned long long support#83
Open
tingshao wants to merge 1 commit intointel:masterfrom
Open
Add long long and unsigned long long support#83tingshao wants to merge 1 commit intointel:masterfrom
tingshao wants to merge 1 commit intointel:masterfrom
Conversation
Use v8::Number when representing attributes, and return value. Parameters are also supported.
tingshao
force-pushed
the
support_long_long
branch
from
89fec4c to
6232426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use v8::Number when representing attributes, and return value.
Parameters are also supported.
@kenny-y This uses v8::Number when creating v8 objs for int64, otherwise, there will be compile error.
PTAL, thanks.