Skip to content

fix: resolve deprecated nullable parameter typing for PHP 8.4 compatibility #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
betooliveirawj wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: resolve deprecated nullable parameter typing for PHP 8.4 compatibility #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8152ea
fix: typing error when instaling on php 8.4
betooliveirawj May 14, 2026
a000d41
fix: fix typing erros on contructor of some especific classes
betooliveirawj May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Helper/Data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public function unserializeData($data)
/**
* @param array|null $data
*/
public function saveResultQuotes(array $data = null)
public function saveResultQuotes(?array $data = null)
{
$this->customerSession->setData(self::RESULT_QUOTES, $data);
}
Expand Down Expand Up @@ -539,7 +539,7 @@ protected function getTrack($trackingUrl)
* @return array|null
* @throws \Magento\Framework\Exception\NoSuchEntityException
*/
public function getAdditionalInformation(array $additional = null)
public function getAdditionalInformation(?array $additional = null)
{
$result = [
'client_type' => $this->getCustomerGroup(),
Expand Down
4 changes: 2 additions & 2 deletions Model/Config/CronConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public function __construct(
\Magento\Framework\App\Config\ScopeConfigInterface $config,
\Magento\Framework\App\Cache\TypeListInterface $cacheTypeList,
\Magento\Framework\App\Config\ValueFactory $configValueFactory,
\Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
\Magento\Framework\Data\Collection\AbstractDb $resourceCollection = null,
\Magento\Framework\Model\ResourceModel\AbstractResource|null $resource = null,
\Magento\Framework\Data\Collection\AbstractDb|null $resourceCollection = null,
$runModelPath = '',
array $data = []
) {
Expand Down
4 changes: 2 additions & 2 deletions Model/ResourceModel/Shipment/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ public function __construct(
FetchStrategyInterface $fetchStrategy,
ManagerInterface $eventManager,
StoreManagerInterface $storeManager,
AdapterInterface $connection = null,
AbstractDb $resource = null
AdapterInterface|null $connection = null,
AbstractDb|null $resource = null
)
{
$this->_init(
Expand Down