-
Notifications
You must be signed in to change notification settings - Fork 2
Update dependency requests to v2.32.4 [SECURITY] #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request contains a potential security vulnerability in the requests library version 2.32.4, which has a known security advisory (CVE-2024-47081) related to potential credential leakage, and it is recommended to review the CVE details and consider updating to a patched version.
|
| Vulnerability | Potential Dependency Vulnerability |
|---|---|
| Description | The project is using requests 2.32.4, which has a known security advisory (CVE-2024-47081) related to potential credential leakage. While the specific version is mentioned in the advisory, the exact impact and exploitability would require further investigation. It is recommended to review the CVE details and consider updating to a patched version. |
Lines 5 to 11 in abbb346
| description= 'Tool for automating Vulnerability Risk Management and Software Supply Chain Security Measures', | |
| version='0.0.1', | |
| py_modules=['scsctl'], | |
| install_requires=['click==8.1.3', 'clickhouse-driver==0.2.6', 'numpy==1.25.0', 'requests==2.32.4','questionary==1.10.0','tabulate==0.9.0'], | |
| entry_points={ | |
| 'console_scripts': [ | |
| 'scsctl = scsctl.app:cli' |
All finding details can be found in the DryRun Security Dashboard.
| version='0.0.1', | ||
| py_modules=['scsctl'], | ||
| install_requires=['click==8.1.3', 'clickhouse-driver==0.2.6', 'numpy==1.25.0', 'requests==2.31.0','questionary==1.10.0','tabulate==0.9.0'], | ||
| install_requires=['click==8.1.3', 'clickhouse-driver==0.2.6', 'numpy==1.25.0', 'requests==2.32.4','questionary==1.10.0','tabulate==0.9.0'], |
Check warning
Code scanning / Pylintpython3 (reported by Codacy)
Line too long (143/100) Warning
| version='0.0.1', | ||
| py_modules=['scsctl'], | ||
| install_requires=['click==8.1.3', 'clickhouse-driver==0.2.6', 'numpy==1.25.0', 'requests==2.31.0','questionary==1.10.0','tabulate==0.9.0'], | ||
| install_requires=['click==8.1.3', 'clickhouse-driver==0.2.6', 'numpy==1.25.0', 'requests==2.32.4','questionary==1.10.0','tabulate==0.9.0'], |
Check warning
Code scanning / Pylint (reported by Codacy)
Exactly one space required after comma Warning
| version='0.0.1', | ||
| py_modules=['scsctl'], | ||
| install_requires=['click==8.1.3', 'clickhouse-driver==0.2.6', 'numpy==1.25.0', 'requests==2.31.0','questionary==1.10.0','tabulate==0.9.0'], | ||
| install_requires=['click==8.1.3', 'clickhouse-driver==0.2.6', 'numpy==1.25.0', 'requests==2.32.4','questionary==1.10.0','tabulate==0.9.0'], |
Check warning
Code scanning / Pylint (reported by Codacy)
Line too long (143/100) Warning
5445a23 to
abbb346
Compare
This PR contains the following updates:
==2.31.0→==2.32.4GitHub Vulnerability Alerts
CVE-2024-35195
When using a
requests.Session, if the first request to a given origin is made withverify=False, TLS certificate verification may remain disabled for all subsequent requests to that origin, even ifverify=Trueis explicitly specified later.This occurs because the underlying connection is reused from the session's connection pool, causing the initial TLS verification setting to persist for the lifetime of the pooled connection. As a result, applications may unintentionally send requests without certificate verification, leading to potential man-in-the-middle attacks and compromised confidentiality or integrity.
This behavior affects versions of
requestsprior to 2.32.0.CVE-2024-47081
Impact
Due to a URL parsing issue, Requests releases prior to 2.32.4 may leak .netrc credentials to third parties for specific maliciously-crafted URLs.
Workarounds
For older versions of Requests, use of the .netrc file can be disabled with
trust_env=Falseon your Requests Session (docs).References
https://github.com/psf/requests/pull/6965
https://seclists.org/fulldisclosure/2025/Jun/2
Release Notes
psf/requests (requests)
v2.32.4Compare Source
Security
environment will retrieve credentials for the wrong hostname/machine from a
netrc file.
Improvements
Deprecations
v2.32.3Compare Source
Bugfixes
HTTPAdapter. (#6716)
without the
sslmodule. (#6724)v2.32.2Compare Source
Deprecations
To provide a more stable migration for custom HTTPAdapters impacted
by the CVE changes in 2.32.0, we've renamed
_get_connectiontoa new public API,
get_connection_with_tls_context. Existing customHTTPAdapters will need to migrate their code to use this new API.
get_connectionis considered deprecated in all versions of Requests>=2.32.0.A minimal (2-line) example has been provided in the linked PR to ease
migration, but we strongly urge users to evaluate if their custom adapter
is subject to the same issue described in CVE-2024-35195. (#6710)
v2.32.1Compare Source
Bugfixes
v2.32.0Compare Source
Security
verify=Falseon the first request from aSession will cause subsequent requests to the same origin to also ignore
cert verification, regardless of the value of
verify.(GHSA-9wx4-h78v-vm56)
Improvements
verify=Truenow reuses a global SSLContext which should improverequest time variance between first and subsequent requests. It should
also minimize certificate load time on Windows systems when using a Python
version built with OpenSSL 3.x. (#6667)
(
chardetorcharset_normalizer) when repackaged or vendored.This enables
pipand other projects to minimize their vendoringsurface area. The
Response.text()andapparent_encodingAPIswill default to
utf-8if neither library is present. (#6702)Bugfixes
calculated in the request content-length. (#6589)
/(path separator) could leadurllib3 to unnecessarily reparse the request URI. (#6644)
Deprecations
Documentation
Packaging
The source files for the projects (formerly
requests) is now locatedin
src/requestsin the Requests sdist. (#6506)using
hatchling. This should not impact the average user, but extremely oldversions of packaging utilities may have issues with the new packaging format.
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.