Conversation
* updated PR automation Slow run to avoid executing all the optional containers * update history routing constants to fix broken tabs --------- Co-authored-by: Daniele Rosetti <55402684+drosetti@users.noreply.github.com> Co-authored-by: Matteo Lodi <30625432+mlodic@users.noreply.github.com>
* refactor: remove Greynoise_Labs analyzer * chore: delete associated periodic tasks
Bumps [apkid](https://github.com/rednaga/APKiD) from 2.1.4 to 3.1.0. - [Release notes](https://github.com/rednaga/APKiD/releases) - [Commits](rednaga/APKiD@v2.1.4...v3.1.0) --- updated-dependencies: - dependency-name: apkid dependency-version: 3.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* updated PR automation Slow run to avoid executing all the optional containers * fix(views): scope plugin_state_viewer to user organization This prevents a cross-organization information disclosure where users could see disabled plugin states from all organizations. --------- Co-authored-by: Daniele Rosetti <55402684+drosetti@users.noreply.github.com> Co-authored-by: Matteo Lodi <30625432+mlodic@users.noreply.github.com>
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Worth considering. View full project report here.
| else: | ||
| raise AnalyzerConfigurationException( | ||
| f"observable '{self.observable_name}' is not a valid email. " | ||
| f"GENERIC type only supports email observables for HudsonRock" |
Contributor
There was a problem hiding this comment.
Suggested change
| f"GENERIC type only supports email observables for HudsonRock" | |
| "GENERIC type only supports email observables for HudsonRock" |
f-string is unnecessary here. This can just be a string. More.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for creating a new release
CHANGELOG.mdfor the new version. Tag another maintainer to review the Changelog and wait for their feedback.docker/.envandfrontend/package.json.developand set it as apre-release. Remember to prepend avto the version number.Write the following statement there (change the version number):
masterbranch. Note: Only use "Merge and commit" as the merge strategy and not "Squash and merge". Using "Squash and merge" makes history between branches misaligned.pre-releasetolatest release.