Skip to content

[_]: fix/list header #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xabg2 merged 2 commits into from
Feb 11, 2026
Merged

[_]: fix/list header #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3d54dc
feat: stick the header at the top
xabg2 Feb 11, 2026
a2dd7d3
fix: list snapshot
xabg2 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@internxt/ui",
"version": "0.1.2",
"version": "0.1.3",
"description": "Library of Internxt components",
"repository": {
"type": "git",
Expand Down
37 changes: 22 additions & 15 deletions src/components/list/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export interface ListProps<T, F> {
disableItemCompositionStyles?: boolean;
onMouseEnter?: () => void;
onMouseLeave?: () => void;
headerBackgroundColor?: string;
keyBoardShortcutActions?: {
onShiftFKeysPressed?: () => void;
onRKeyPressed?: () => void;
Expand Down Expand Up @@ -118,6 +119,9 @@ export interface ListProps<T, F> {
* @property {() => void} [onMouseLeave]
* - Optional callback triggered when the mouse leaves the list.
*
* @property {string} [headerBackgroundColor]
* - Optional background color for the header.
*
* @property {
* { onShiftFKeysPressed?: () => void; onRKeyPressed?: () => void; onBackspaceKeyPressed?: () => void }
* } [keyBoardShortcutActions]
Expand Down Expand Up @@ -151,6 +155,7 @@ const List = <T extends { id: number }, F extends keyof T>({
disableItemCompositionStyles,
onMouseEnter,
onMouseLeave,
headerBackgroundColor = 'bg-surface',
keyBoardShortcutActions,
disableKeyboardShortcuts,
}: ListProps<T, F>): JSX.Element => {
Expand Down Expand Up @@ -298,21 +303,23 @@ const List = <T extends { id: number }, F extends keyof T>({
>
{/* BODY */}
<div id="scrollableList" className="flex h-full flex-col min-w-max overflow-x-hidden overflow-y-auto">
{!isEmptyState ? (
<ListHeader
selectedItems={selectedItems}
onTopSelectionCheckboxClick={onTopSelectionCheckboxClick}
items={items}
header={header}
orderBy={orderBy}
onOrderableColumnClicked={onOrderableColumnClicked}
menu={menu}
displayMenuDiv={displayMenuDiv}
isVerticalScrollbarVisible={isVerticalScrollbarVisible}
checkboxDataCy={checkboxDataCy}
onClose={onCloseContextMenu}
/>
) : null}
<div className={`sticky top-0 z-10 ${headerBackgroundColor}`}>
{!isEmptyState ? (
<ListHeader
selectedItems={selectedItems}
onTopSelectionCheckboxClick={onTopSelectionCheckboxClick}
items={items}
header={header}
orderBy={orderBy}
onOrderableColumnClicked={onOrderableColumnClicked}
menu={menu}
displayMenuDiv={displayMenuDiv}
isVerticalScrollbarVisible={isVerticalScrollbarVisible}
checkboxDataCy={checkboxDataCy}
onClose={onCloseContextMenu}
/>
) : null}
</div>
{isEmptyState ? (
emptyState
) : items.length > 0 && !forceLoading ? (
Expand Down
212 changes: 110 additions & 102 deletions src/components/list/__test__/__snapshots__/List.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,69 +14,73 @@ exports[`List component > should match snapshot 1`] = `
id="scrollableList"
>
<div
class="flex min-w-max h-12 shrink-0 flex-row px-5"
class="sticky top-0 z-10 bg-surface"
>
<div
class="flex h-full min-w-full flex-row items-center border-b border-gray-10"
class="flex min-w-max h-12 shrink-0 flex-row px-5"
>
<div
class="flex h-full flex-row items-center justify-between pr-4"
class="flex h-full min-w-full flex-row items-center border-b border-gray-10"
>
<label
class="relative h-5 w-5 rounded focus-within:outline-primary undefined"
<div
class="flex h-full flex-row items-center justify-between pr-4"
>
<div
class="relative flex h-5 w-5 cursor-pointer flex-col items-center justify-center rounded border text-white border-primary bg-primary"
<label
class="relative h-5 w-5 rounded focus-within:outline-primary undefined"
>
<svg
class="absolute -inset-px"
fill="none"
height="20"
viewBox="0 0 20 20"
width="20"
xmlns="http://www.w3.org/2000/svg"
<div
class="relative flex h-5 w-5 cursor-pointer flex-col items-center justify-center rounded border text-white border-primary bg-primary"
>
<rect
fill="currentColor"
height="2"
rx="1"
width="12"
x="4"
y="9"
/>
</svg>
</div>
<input
checked=""
class="base-checkbox h-0 w-0 appearance-none opacity-0"
readonly=""
type="checkbox"
/>
</label>
</div>
<button
class="flex h-full shrink-0 flex-row items-center space-x-1.5 text-base font-medium text-gray-60 100px cursor-pointer hover:text-gray-80"
data-cy="false"
>
<span
<svg
class="absolute -inset-px"
fill="none"
height="20"
viewBox="0 0 20 20"
width="20"
xmlns="http://www.w3.org/2000/svg"
>
<rect
fill="currentColor"
height="2"
rx="1"
width="12"
x="4"
y="9"
/>
</svg>
</div>
<input
checked=""
class="base-checkbox h-0 w-0 appearance-none opacity-0"
readonly=""
type="checkbox"
/>
</label>
</div>
<button
class="flex h-full shrink-0 flex-row items-center space-x-1.5 text-base font-medium text-gray-60 100px cursor-pointer hover:text-gray-80"
data-cy="false"
>
Name
</span>
</button>
<button
class="flex h-full shrink-0 flex-row items-center space-x-1.5 text-base font-medium text-gray-60 50px cursor-pointer hover:text-gray-80"
data-cy="false"
>
<span
<span
data-cy="false"
>
Name
</span>
</button>
<button
class="flex h-full shrink-0 flex-row items-center space-x-1.5 text-base font-medium text-gray-60 50px cursor-pointer hover:text-gray-80"
data-cy="false"
>
Age
</span>
</button>
<div
class="flex h-full w-12 shrink-0"
/>
<span
data-cy="false"
>
Age
</span>
</button>
<div
class="flex h-full w-12 shrink-0"
/>
</div>
</div>
</div>
<div>
Expand Down Expand Up @@ -208,69 +212,73 @@ exports[`List component > should match snapshot 1`] = `
id="scrollableList"
>
<div
class="flex min-w-max h-12 shrink-0 flex-row px-5"
class="sticky top-0 z-10 bg-surface"
>
<div
class="flex h-full min-w-full flex-row items-center border-b border-gray-10"
class="flex min-w-max h-12 shrink-0 flex-row px-5"
>
<div
class="flex h-full flex-row items-center justify-between pr-4"
class="flex h-full min-w-full flex-row items-center border-b border-gray-10"
>
<label
class="relative h-5 w-5 rounded focus-within:outline-primary undefined"
<div
class="flex h-full flex-row items-center justify-between pr-4"
>
<div
class="relative flex h-5 w-5 cursor-pointer flex-col items-center justify-center rounded border text-white border-primary bg-primary"
<label
class="relative h-5 w-5 rounded focus-within:outline-primary undefined"
>
<svg
class="absolute -inset-px"
fill="none"
height="20"
viewBox="0 0 20 20"
width="20"
xmlns="http://www.w3.org/2000/svg"
<div
class="relative flex h-5 w-5 cursor-pointer flex-col items-center justify-center rounded border text-white border-primary bg-primary"
>
<rect
fill="currentColor"
height="2"
rx="1"
width="12"
x="4"
y="9"
/>
</svg>
</div>
<input
checked=""
class="base-checkbox h-0 w-0 appearance-none opacity-0"
readonly=""
type="checkbox"
/>
</label>
</div>
<button
class="flex h-full shrink-0 flex-row items-center space-x-1.5 text-base font-medium text-gray-60 100px cursor-pointer hover:text-gray-80"
data-cy="false"
>
<span
<svg
class="absolute -inset-px"
fill="none"
height="20"
viewBox="0 0 20 20"
width="20"
xmlns="http://www.w3.org/2000/svg"
>
<rect
fill="currentColor"
height="2"
rx="1"
width="12"
x="4"
y="9"
/>
</svg>
</div>
<input
checked=""
class="base-checkbox h-0 w-0 appearance-none opacity-0"
readonly=""
type="checkbox"
/>
</label>
</div>
<button
class="flex h-full shrink-0 flex-row items-center space-x-1.5 text-base font-medium text-gray-60 100px cursor-pointer hover:text-gray-80"
data-cy="false"
>
Name
</span>
</button>
<button
class="flex h-full shrink-0 flex-row items-center space-x-1.5 text-base font-medium text-gray-60 50px cursor-pointer hover:text-gray-80"
data-cy="false"
>
<span
<span
data-cy="false"
>
Name
</span>
</button>
<button
class="flex h-full shrink-0 flex-row items-center space-x-1.5 text-base font-medium text-gray-60 50px cursor-pointer hover:text-gray-80"
data-cy="false"
>
Age
</span>
</button>
<div
class="flex h-full w-12 shrink-0"
/>
<span
data-cy="false"
>
Age
</span>
</button>
<div
class="flex h-full w-12 shrink-0"
/>
</div>
</div>
</div>
<div>
Expand Down