Skip to content

[_]: fix/add z index to the list header #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xabg2 merged 3 commits into from
Feb 13, 2026
Merged

[_]: fix/add z index to the list header #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
388d14c
fix: add z index to the list header
xabg2 Feb 12, 2026
c9773da
tests: list snapshot
xabg2 Feb 13, 2026
8aa0d7f
test: List Item snapshot
xabg2 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@internxt/ui",
"version": "0.1.3",
"version": "0.1.4",
"description": "Library of Internxt components",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions src/components/list/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,12 @@ const List = <T extends { id: number }, F extends keyof T>({
return (
<div
id="generic-list-component"
className={`relative flex h-full flex-col overflow-x-auto overflow-y-hidden ${className}`}
className={`relative isolate flex h-full flex-col overflow-x-auto overflow-y-hidden ${className}`}
ref={containerRef}
>
{/* BODY */}
<div id="scrollableList" className="flex h-full flex-col min-w-max overflow-x-hidden overflow-y-auto">
<div className={`sticky top-0 z-10 ${headerBackgroundColor}`}>
<div className={`sticky top-0 z-50 ${headerBackgroundColor}`}>
{!isEmptyState ? (
<ListHeader
selectedItems={selectedItems}
Expand Down
2 changes: 1 addition & 1 deletion src/components/list/ListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ const ListItem = <T extends { id: number }>({
ref={rootWrapperRef}
className={`group relative flex h-14 flex-row items-center pl-14 pr-5 ${
selected ? 'bg-primary/10 text-gray-100 dark:bg-primary/20' : 'focus-within:bg-gray-1 hover:bg-gray-1'
}`}
} ${isOpen ? 'z-40' : ''}`}
onMouseEnter={onMouseEnter}
onMouseLeave={onMouseLeave}
>
Expand Down
16 changes: 8 additions & 8 deletions src/components/list/__test__/__snapshots__/List.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ exports[`List component > should match snapshot 1`] = `
"baseElement": <body>
<div>
<div
class="relative flex h-full flex-col overflow-x-auto overflow-y-hidden undefined"
class="relative isolate flex h-full flex-col overflow-x-auto overflow-y-hidden undefined"
id="generic-list-component"
>
<div
class="flex h-full flex-col min-w-max overflow-x-hidden overflow-y-auto"
id="scrollableList"
>
<div
class="sticky top-0 z-10 bg-surface"
class="sticky top-0 z-50 bg-surface"
>
<div
class="flex min-w-max h-12 shrink-0 flex-row px-5"
Expand Down Expand Up @@ -85,7 +85,7 @@ exports[`List component > should match snapshot 1`] = `
</div>
<div>
<div
class="group relative flex h-14 flex-row items-center pl-14 pr-5 bg-primary/10 text-gray-100 dark:bg-primary/20"
class="group relative flex h-14 flex-row items-center pl-14 pr-5 bg-primary/10 text-gray-100 dark:bg-primary/20 "
>
<div
class="absolute left-5 top-0 flex h-full w-0 flex-row items-center justify-start p-0 opacity-0 focus-within:opacity-100 group-hover:opacity-100 opacity-100"
Expand Down Expand Up @@ -147,7 +147,7 @@ exports[`List component > should match snapshot 1`] = `
</div>
</div>
<div
class="group relative flex h-14 flex-row items-center pl-14 pr-5 focus-within:bg-gray-1 hover:bg-gray-1"
class="group relative flex h-14 flex-row items-center pl-14 pr-5 focus-within:bg-gray-1 hover:bg-gray-1 "
>
<div
class="absolute left-5 top-0 flex h-full w-0 flex-row items-center justify-start p-0 opacity-0 focus-within:opacity-100 group-hover:opacity-100 false"
Expand Down Expand Up @@ -204,15 +204,15 @@ exports[`List component > should match snapshot 1`] = `
</body>,
"container": <div>
<div
class="relative flex h-full flex-col overflow-x-auto overflow-y-hidden undefined"
class="relative isolate flex h-full flex-col overflow-x-auto overflow-y-hidden undefined"
id="generic-list-component"
>
<div
class="flex h-full flex-col min-w-max overflow-x-hidden overflow-y-auto"
id="scrollableList"
>
<div
class="sticky top-0 z-10 bg-surface"
class="sticky top-0 z-50 bg-surface"
>
<div
class="flex min-w-max h-12 shrink-0 flex-row px-5"
Expand Down Expand Up @@ -283,7 +283,7 @@ exports[`List component > should match snapshot 1`] = `
</div>
<div>
<div
class="group relative flex h-14 flex-row items-center pl-14 pr-5 bg-primary/10 text-gray-100 dark:bg-primary/20"
class="group relative flex h-14 flex-row items-center pl-14 pr-5 bg-primary/10 text-gray-100 dark:bg-primary/20 "
>
<div
class="absolute left-5 top-0 flex h-full w-0 flex-row items-center justify-start p-0 opacity-0 focus-within:opacity-100 group-hover:opacity-100 opacity-100"
Expand Down Expand Up @@ -345,7 +345,7 @@ exports[`List component > should match snapshot 1`] = `
</div>
</div>
<div
class="group relative flex h-14 flex-row items-center pl-14 pr-5 focus-within:bg-gray-1 hover:bg-gray-1"
class="group relative flex h-14 flex-row items-center pl-14 pr-5 focus-within:bg-gray-1 hover:bg-gray-1 "
>
<div
class="absolute left-5 top-0 flex h-full w-0 flex-row items-center justify-start p-0 opacity-0 focus-within:opacity-100 group-hover:opacity-100 false"
Expand Down
4 changes: 2 additions & 2 deletions src/components/list/__test__/__snapshots__/ListItem.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`ListItem > should match snapshot 1`] = `
"baseElement": <body>
<div>
<div
class="group relative flex h-14 flex-row items-center pl-14 pr-5 focus-within:bg-gray-1 hover:bg-gray-1"
class="group relative flex h-14 flex-row items-center pl-14 pr-5 focus-within:bg-gray-1 hover:bg-gray-1 "
>
<div
class="absolute left-5 top-0 flex h-full w-0 flex-row items-center justify-start p-0 opacity-0 focus-within:opacity-100 group-hover:opacity-100 false"
Expand Down Expand Up @@ -56,7 +56,7 @@ exports[`ListItem > should match snapshot 1`] = `
</body>,
"container": <div>
<div
class="group relative flex h-14 flex-row items-center pl-14 pr-5 focus-within:bg-gray-1 hover:bg-gray-1"
class="group relative flex h-14 flex-row items-center pl-14 pr-5 focus-within:bg-gray-1 hover:bg-gray-1 "
>
<div
class="absolute left-5 top-0 flex h-full w-0 flex-row items-center justify-start p-0 opacity-0 focus-within:opacity-100 group-hover:opacity-100 false"
Expand Down