Skip to content

Conversation

@moyogo
Copy link
Contributor

@moyogo moyogo commented May 16, 2025

In Yaghoubi romanization ږ should be romanized with ẕ̌ (1E95 LATIN SMALL LETTER Z WITH LINE BELOW, 030C COMBINING CARON) as U+0331 COMBINING MACRON BELOW is used in all other letter with line below cases, instead of with U+0332 COMBINING LOW LINE.

In Yaghoubi romanization ږ should be romanized with ẕ̌ (1E95 LATIN SMALL LETTER
Z WITH LINE BELOW, 030C COMBINING CARON) as U+0331 COMBINING MACRON BELOW is
used in all other letter with line below cases, instead of with U+0332
COMBINING LOW LINE.
@moyogo
Copy link
Contributor Author

moyogo commented May 16, 2025

I don’t know if DIN:nep:Deva:33904-2018 and DIN:hin:Deva:33904-2018 explicitly use U+0332 in the original document but it’s odd U+0331 is used in precomposed characters like "ḵ" ("क़", "ḵa") and U+0332 is used in composed characters like "g̲" ("ग़", "g̲a"). It looks like these are mistakes and should use U+0331 as well unless the reference DIN document specifically uses U+0332.

@ronaldtse ronaldtse requested a review from Copilot May 16, 2025 09:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • maps/bgnpcgn-prs-Arab-Latn-yaghoubi.imp: Language not supported

@ronaldtse
Copy link
Contributor

Thank you @moyogo ! The test failures are not related to the changes, and the change is good to go.

You are probably correct that U+0332 combining caron should have used instead of U+0331 for all characters in this map. Would you be able to extend the PR to fix those as well? Thanks!

@ronaldtse ronaldtse added the bug Something isn't working label May 16, 2025
@github-project-automation github-project-automation bot moved this to TRIAGE in Interscript May 16, 2025
U+0331 is used in precomposed characters like "ḵ" ("क़", "ḵa") when
decomposed. This changes composed characters like "g̲" ("ग़", "g̲a")
to "g̱" using U+0331 instead of U+0332, , or composed characters like
"h̲" ("ह़", "ẖa") to precomposed characters like "ẖ".
@moyogo
Copy link
Contributor Author

moyogo commented May 16, 2025

@ronaldtse I’ve added a commit with the DIN 33904-2018 changes.

@github-project-automation github-project-automation bot moved this from TRIAGE to In Progress in Interscript May 16, 2025
@ronaldtse
Copy link
Contributor

Thank you very much for your contribution @moyogo !

@ronaldtse ronaldtse merged commit 0fde450 into interscript:main May 16, 2025
1 check failed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Interscript May 16, 2025
@moyogo moyogo deleted the 0332-to-0331 branch September 6, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants