-
Notifications
You must be signed in to change notification settings - Fork 2
Replace U+0332 by U+0331 #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In Yaghoubi romanization ږ should be romanized with ẕ̌ (1E95 LATIN SMALL LETTER Z WITH LINE BELOW, 030C COMBINING CARON) as U+0331 COMBINING MACRON BELOW is used in all other letter with line below cases, instead of with U+0332 COMBINING LOW LINE.
|
I don’t know if DIN:nep:Deva:33904-2018 and DIN:hin:Deva:33904-2018 explicitly use U+0332 in the original document but it’s odd U+0331 is used in precomposed characters like "ḵ" ("क़", "ḵa") and U+0332 is used in composed characters like "g̲" ("ग़", "g̲a"). It looks like these are mistakes and should use U+0331 as well unless the reference DIN document specifically uses U+0332. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- maps/bgnpcgn-prs-Arab-Latn-yaghoubi.imp: Language not supported
|
Thank you @moyogo ! The test failures are not related to the changes, and the change is good to go. You are probably correct that U+0332 combining caron should have used instead of U+0331 for all characters in this map. Would you be able to extend the PR to fix those as well? Thanks! |
U+0331 is used in precomposed characters like "ḵ" ("क़", "ḵa") when
decomposed. This changes composed characters like "g̲" ("ग़", "g̲a")
to "g̱" using U+0331 instead of U+0332, , or composed characters like
"h̲" ("ह़", "ẖa") to precomposed characters like "ẖ".
|
@ronaldtse I’ve added a commit with the DIN 33904-2018 changes. |
|
Thank you very much for your contribution @moyogo ! |
In Yaghoubi romanization ږ should be romanized with ẕ̌ (1E95 LATIN SMALL LETTER Z WITH LINE BELOW, 030C COMBINING CARON) as U+0331 COMBINING MACRON BELOW is used in all other letter with line below cases, instead of with U+0332 COMBINING LOW LINE.