fix: receiver validation (2A $200) + fee accumulation system (2C $200)#8
Open
wyslsz wants to merge 3 commits into
Open
fix: receiver validation (2A $200) + fee accumulation system (2C $200)#8wyslsz wants to merge 3 commits into
wyslsz wants to merge 3 commits into
Conversation
- Add IntuitionFeeProxy_ReceiverMismatch error to Errors library - Add receiver validation in deposit(), createAtoms(), createTriples(), depositBatch() - Add Foundry test suite (ReceiverValidation.t.sol) with 9 test cases - Tests cover: happy path, revert on mismatch, attack scenario prevention Fixes intuition-box#1 Bounty: #2A (00 USDC)
- accumulatedFees state replacing auto-forwarding - withdrawFees() for fee recipient - withdrawFeesTo() for admin emergency - getAccumulatedFees() view function - FeesWithdrawn event - Reentrancy-safe: state restored on transfer failure Bounty: #2C ($200 USDC)
wyslsz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounties Included
2A: Fix Issue #1 — Receiver Validation ($200 USDC)
receiver == msg.sendercheck todeposit(),createAtoms(),createTriples(),depositBatch()IntuitionFeeProxy_ReceiverMismatcherror2C: Withdraw Function — Fee Accumulation ($200 USDC)
withdrawFees()— fee recipient claims accumulated feeswithdrawFeesTo(address)— admin emergency withdrawalgetAccumulatedFees()— view functionFeesWithdrawneventTotal Bounty: $400 USDC