Update the bundle for gobl 0.504.0 (FI + DK addons) - #35
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 72.43% 72.58% +0.15%
==========================================
Files 47 47
Lines 1988 1988
==========================================
+ Hits 1440 1443 +3
+ Misses 468 465 -3
Partials 80 80 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rilla
force-pushed
the
add-fi-finvoice
branch
2 times, most recently
from
July 31, 2026 13:57
1362433 to
5218715
Compare
rilla
marked this pull request as ready for review
August 5, 2026 10:54
Resolve npm security alerts
samlown
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
gobl 0.504.0 approves two new external addons —
fi-finvoice-v3(Finland) anddk-oioubl-v2(Denmark) — so the bundle needs both to satisfyTestApprovedAddonsAvailable. Neither can land alone: with gobl bumped, whichever is missing fails that test.Changes
internal/ops/sign.gopasses bare GOBL Net addresses (SignOptions.Issuer/Audiencebecomenet.Address) rather thangobl:URIs. Nothing populates those fields yet, so there are no callers to update.fi-finvoice-v3atgobl.fi.finvoice v0.0.2— the version built against 0.504.0'scbc.Codecredit-transfer fields.dk-oioubl-v2atgobl.dk.oioubl v0.0.1.All ten approved addons now register through the bundle, and the full suite passes.