Skip to content

Update the bundle for gobl 0.504.0 (FI + DK addons) - #35

Merged
rilla merged 6 commits into
mainfrom
add-fi-finvoice
Aug 5, 2026
Merged

Update the bundle for gobl 0.504.0 (FI + DK addons)#35
rilla merged 6 commits into
mainfrom
add-fi-finvoice

Conversation

@rilla

@rilla rilla commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Context

gobl 0.504.0 approves two new external addons — fi-finvoice-v3 (Finland) and dk-oioubl-v2 (Denmark) — so the bundle needs both to satisfy TestApprovedAddonsAvailable. Neither can land alone: with gobl bumped, whichever is missing fails that test.

Changes

  • Update to gobl 0.504.0 — the release also changes the signing claims, so internal/ops/sign.go passes bare GOBL Net addresses (SignOptions.Issuer/Audience become net.Address) rather than gobl: URIs. Nothing populates those fields yet, so there are no callers to update.
  • fi-finvoice-v3 at gobl.fi.finvoice v0.0.2 — the version built against 0.504.0's cbc.Code credit-transfer fields.
  • dk-oioubl-v2 at gobl.dk.oioubl v0.0.1.

All ten approved addons now register through the bundle, and the full suite passes.

@codecov-commenter

codecov-commenter commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.58%. Comparing base (44a7221) to head (eaaff0b).

Files with missing lines Patch % Lines
internal/ops/sign.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   72.43%   72.58%   +0.15%     
==========================================
  Files          47       47              
  Lines        1988     1988              
==========================================
+ Hits         1440     1443       +3     
+ Misses        468      465       -3     
  Partials       80       80              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rilla
rilla force-pushed the add-fi-finvoice branch 2 times, most recently from 1362433 to 5218715 Compare July 31, 2026 13:57
@rilla
rilla requested a review from samlown July 31, 2026 14:12
@rilla
rilla force-pushed the add-fi-finvoice branch from 5218715 to 480d976 Compare August 4, 2026 13:49
@rilla
rilla marked this pull request as ready for review August 5, 2026 10:54
@rilla rilla changed the title Add fi-finvoice-v3 addon to the bundle Update the bundle for gobl 0.504.0 (FI + DK addons) Aug 5, 2026
@rilla
rilla merged commit 026ec83 into main Aug 5, 2026
2 checks passed
@rilla
rilla deleted the add-fi-finvoice branch August 5, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants