Recover the BIC when UBL nests it inside the financial institution - #124
Closed
rilla wants to merge 2 commits into
Closed
Recover the BIC when UBL nests it inside the financial institution#124rilla wants to merge 2 commits into
rilla wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 81.40% 81.46% +0.05%
==========================================
Files 28 28
Lines 2167 2174 +7
==========================================
+ Hits 1764 1771 +7
Misses 265 265
Partials 138 138 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing this. It came out of reading around the v0.504.0 payment change rather than from a reported problem, and the case for it rests on the nested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
UBL can carry the payee's BIC in two places: on
cac:FinancialInstitutionBranch/cbc:ID(BT-86), or one level deeper undercac:FinancialInstitution/cbc:ID. The parser only read the first, so a document using the nested form lost the BIC entirely.test/data/parse/peppol/nbio-stuck-ubl.xmlis one of those documents — itsGKCCBEBBnever reached the parsed invoice, as the golden output shows. The wire model already declaredFinancialInstitutionfor this element, but nothing read it.Changes
FinancialInstitution/IDwhen the branch carries no ID of its own.cbc.Code'sIsEmptyinnewCreditTransferAccount, now that those fields are codes.Outbound is unchanged: the BIC still goes to BT-86. The fallback only fires where the parser previously produced nothing, so no existing document parses differently.