Fix empty fields in payment output

[alvarolivie]

Summary

• newCreditTransferAccount now returns nil instead of an empty FinancialAccount when no fields are set
• CardAccount.PrimaryAccountNumberID only set when Last4 is non-empty
• PaymentMandate.ID only set when DirectDebit.Ref is non-empty
• PaymentTerms note only appended when Terms.Notes is non-empty

[codecov-commenter]

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.09%. Comparing base (59d3ef8) to head (79609de).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
payment.go	71.42%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   76.12%   77.09%   +0.97%     
==========================================
  Files          26       26              
  Lines        1889     1895       +6     
==========================================
+ Hits         1438     1461      +23     
+ Misses        329      312      -17     
  Partials      122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR aims to reduce empty/meaningless XML output in generated UBL payment structures by omitting optional elements/fields when the corresponding GOBL payment data is empty.

Changes:

• Return nil from newCreditTransferAccount when no account fields are set, avoiding empty financial account output.
• Make card PAN and direct-debit mandate ID conditional on non-empty source values (and move direct-debit payer account under PaymentMandate).
• Only append PaymentTerms notes when Terms.Notes is non-empty.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

PaymentMandate.ID is a non-pointer IDType, so it will still be marshaled as <cbc:ID> with an empty value even when instr.DirectDebit.Ref == "". The conditional assignment here doesn’t actually prevent an empty ID from appearing in the XML; consider making PaymentMandate.ID a *IDType (or implementing custom marshaling) so it can be omitted when unset, and update the parsing side accordingly.

[Copilot]

PaymentMandate is always allocated and assigned whenever instr.DirectDebit != nil, even if both Ref and Account are empty. That will still emit a <cac:PaymentMandate> element (and currently an empty <cbc:ID>), which seems to contradict the goal of avoiding empty output fields. Consider only setting ui.PaymentMeans[0].PaymentMandate when at least one meaningful DirectDebit field is present, otherwise leave it nil.

[Copilot]

CardAccount is always allocated and assigned whenever instr.Card != nil, even when both Last4 and Holder are empty. This can still produce an empty <cac:CardAccount/> element in the XML. To fully avoid empty payment output, consider only setting ui.PaymentMeans[0].CardAccount when at least one card field is non-empty.

Suggested change

	ui.PaymentMeans[0].CardAccount = card
	if card.PrimaryAccountNumberID != nil || card.HolderName != nil {
	ui.PaymentMeans[0].CardAccount = card
	}

[Copilot]

This adds new behavior where newCreditTransferAccount returns nil when no fields are set. There are existing payment conversion tests, but none assert the nil/omission behavior for an empty credit transfer; adding a unit test/fixture covering an empty pay.CreditTransfer would help prevent regressions in the generated XML.

[Copilot]

PaymentTerms are now appended only when pymt.Terms.Notes is non-empty. Since this changes output behavior (previously an empty <cbc:Note/> could be emitted), it would be good to add a conversion test that covers the case where due dates are absent and Terms.Notes is empty to ensure ui.PaymentTerms stays empty.