Extract the it-sdi addon to an external module - #876
Open
rilla wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
- Coverage 94.73% 94.70% -0.03%
==========================================
Files 316 310 -6
Lines 17198 16767 -431
==========================================
- Hits 16292 15879 -413
+ Misses 560 553 -7
+ Partials 346 335 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rilla
marked this pull request as ready for review
June 25, 2026 12:59
rilla
force-pushed
the
externalize-it-sdi-addon
branch
3 times, most recently
from
June 26, 2026 11:29
64c3c4f to
1491d4c
Compare
samlown
approved these changes
Jul 2, 2026
samlown
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Conflicts just need fixing.
rilla
force-pushed
the
externalize-it-sdi-addon
branch
from
July 3, 2026 07:01
1491d4c to
8d1a30a
Compare
Contributor
Author
|
Rebased and fixed conflicts 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it-sdi-v1) to the standalonegithub.com/invopop/gobl.it.sdimodule; the key stays recognised via core's approved-external-addon list.Related: invopop/gobl.fatturapa#71
Pre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.And if you are part of the org: