Skip to content

Extract the it-sdi addon to an external module - #876

Open
rilla wants to merge 1 commit into
mainfrom
externalize-it-sdi-addon
Open

Extract the it-sdi addon to an external module#876
rilla wants to merge 1 commit into
mainfrom
externalize-it-sdi-addon

Conversation

@rilla

@rilla rilla commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
  • Extracts the Italian SDI addon (it-sdi-v1) to the standalone github.com/invopop/gobl.it.sdi module; the key stays recognised via core's approved-external-addon list.
  • Decouples the remaining core tests (IT regime legacy-key migration, totals calculator) from the addon's ext-key constants; addon-behaviour tests move to the module.

Related: invopop/gobl.fatturapa#71

Pre-Review Checklist

  • Opened this PR as a draft
  • Read the CONTRIBUTING.md guide.
  • Performed a self-review of my code.
  • Added thorough tests with at least 90% code coverage.
  • Modified or created example GOBL documents to show my changes in use, if appropriate.
  • Added links to the source of the changes in tax regimes or addons, either structured or in the comments.
  • Run go generate . to ensure that the Schemas and Regime data are up to date.
  • Reviewed and fixed all linter warnings.
  • Been obsessive with pointer nil checks to avoid panics.
  • Updated the CHANGELOG.md with an overview of my changes.
  • Marked this PR as ready for review.

And if you are part of the org:

  • Requested a review from Copilot and fixed or dismissed (with a reason) all the feedback raised.
  • Requested a review from @samlown.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.70%. Comparing base (7a4ad62) to head (8d1a30a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   94.73%   94.70%   -0.03%     
==========================================
  Files         316      310       -6     
  Lines       17198    16767     -431     
==========================================
- Hits        16292    15879     -413     
+ Misses        560      553       -7     
+ Partials      346      335      -11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rilla rilla changed the title Externalise the it-sdi addon to the gobl.it.sdi module Extract the it-sdi addon to an external module Jun 25, 2026
@rilla
rilla marked this pull request as ready for review June 25, 2026 12:59
@rilla
rilla requested a review from samlown June 25, 2026 13:00
@rilla
rilla force-pushed the externalize-it-sdi-addon branch 3 times, most recently from 64c3c4f to 1491d4c Compare June 26, 2026 11:29

@samlown samlown left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Conflicts just need fixing.

@rilla
rilla force-pushed the externalize-it-sdi-addon branch from 1491d4c to 8d1a30a Compare July 3, 2026 07:01
@rilla

rilla commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and fixed conflicts 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants