Add Iceland (IS) tax regime - #887
Open
jaimerabazo wants to merge 5 commits into
Open
Conversation
Author
|
@codecov full review |
Author
|
@copilot full review |
jaimerabazo
force-pushed
the
feat/is-regime
branch
from
July 1, 2026 18:40
81a109d to
004e4ce
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
+ Coverage 94.75% 94.77% +0.01%
==========================================
Files 343 346 +3
Lines 18815 18986 +171
==========================================
+ Hits 17829 17994 +165
- Misses 600 603 +3
- Partials 386 389 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaimerabazo
force-pushed
the
feat/is-regime
branch
from
July 6, 2026 06:45
004e4ce to
4ea2ebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Iceland (
IS) as a new tax regime. Completes Nordic coverage alongsidedk,seandno.Changes
regimes/is/— regime, VSK category (24% / 11%, since 2015), kennitala validation,IdentityTypeKennitala.examples/is/.Design decisions
0–3person,4–7company,8–9temporary). Modeled as one type withIsCompany/IsPersonhelpers rather than mirroring Sweden's split.Out of scope
addons/is/ts236/. Left out here because it requires reading the full spec and ideally a domain-expert review.bill.InvoiceScenarios().Sources
Pre-Review Checklist
go generate .to ensure that the Schemas and Regime data are up to date.And if you are part of the org: