regimes: add Iceland (IS) tax regime - #888
Open
smoltuna wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Iceland (IS) as a new tax regime to GOBL, including VAT category/rates, Kennitala (tax identity) validation + normalization hooks, generated embedded regime/rules/schema updates, and example invoices.
Changes:
- Register the
ISregime and provide itstax.RegimeDef(VAT @ 24%/11% with historical values and sources). - Add Kennitala (10-digit, mod-11) tax identity validation rules and normalization, with unit tests.
- Add Iceland invoice examples (YAML inputs + generated envelope JSON outputs) and regenerate embedded regime/rule/schema data; update the changelog.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| regimes/regimes.go | Registers the new IS regime package for side-effect init. |
| regimes/is/is.go | Defines and registers the Iceland regime (currency, VAT scheme, timezone, sources). |
| regimes/is/tax_categories.go | Defines Iceland VAT category with standard/reduced rates and history. |
| regimes/is/tax_identity.go | Adds Kennitala validation + normalization wiring for tax.Identity. |
| regimes/is/tax_identity_test.go | Tests Kennitala validation and normalization behavior. |
| examples/is/invoice-is-standard.yaml | Standard-rate Iceland invoice example (authoring input). |
| examples/is/invoice-is-reduced.yaml | Reduced-rate Iceland invoice example (authoring input). |
| examples/is/out/invoice-is-standard.json | Generated envelope output for the standard example. |
| examples/is/out/invoice-is-reduced.json | Generated envelope output for the reduced example. |
| data/schemas/tax/regime-code.json | Adds IS to the regime-code JSON schema enum. |
| data/rules/is.json | Generated rules export for Iceland tax identity validation. |
| data/regimes/is.json | Generated embedded regime definition export for Iceland. |
| CHANGELOG.md | Notes the new Iceland regime addition in the unreleased section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
# Conflicts: # CHANGELOG.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Iceland (IS) as a new tax regime, modelled on the recently merged Norway (
regimes/no) and mirroring recent patterns from PR #885 (AU/NZ).Iceland was picked from countries not already in the repo or being added by other open PRs, for its manageable scope, English-language primary sources, and the goal of producing a first regime that is small and easy to review. Happy to adjust anything that doesn't quite fit the project's standards.
tax.KeyZero/tax.KeyExemptfromtax.GlobalVATKeys()— no dedicatedRateDef.[3, 2, 7, 6, 5, 4, 3, 2], same case analysis (remainder 0 → check 0; remainder 1 → never issued). Only the container differs (10 digits with date-encoded positions).is) translations on the regime, tax category, rate names and descriptions.Out of scope
addons/eu/en16931; the Icelandic profile would sit in a futureaddons/is/peppol.Sources
Pre-Review Checklist
regimes/is/)go generate .to ensure that the Schemas and Regime data are up to date.And if you are part of the org: