replace fabricated verify page data with dynamic API response#153
Merged
ionfwsrijan merged 1 commit intoJun 22, 2026
Merged
Conversation
Contributor
Author
|
hi @ionfwsrijan Please review it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #151
What this PR does
This PR connects the Verify page to the backend
/verifyendpoint. It replaces the hardcoded, fabricated data arrays with dynamic React state that accurately reflects the actual sandbox execution results and timeline events. It also resolves a React key collision warning introduced by Strict Mode.Type of change
ML tier (if applicable)
Stack affected
Changes
Backend
Frontend
frontend/src/app/pages/verify.tsx: Removed staticverificationChecksandtimelinearrays. Added auseEffecthook to callverify(jobId)via the API client and dynamically update the UI based on the sandbox response. Utilizedcrypto.randomUUID()to prevent React Strict Mode key duplication warnings.New dependencies
Database / schema changes
Testing
How did you test this?
Tested locally by navigating to the Verify page after completing a scan. Verified that the loading state accurately appears while the backend processes the sandbox checks, and that the UI dynamically updates with the real success/failure results once the API call resolves. Checked the browser console to confirm the "two children with the same key" error is completely resolved.
Checklist
console.erroror unhandled Python exceptions introducedrequirements.txt/package.jsonupdated if new dependencies added.pkl,.pt, etc.) are gitignored, not committedAnything reviewers should focus on
Take a look at the fallback logic inside the
useEffectblock inverify.tsx. Ifres.checksisn't explicitly returned as an array from the backend, the UI safely maps the top-level pass/fail status into a generic "Sandbox Verification Result" card to ensure the page doesn't crash.Screenshots (if UI changed)
(The Verify page now displays a "Running" spinner during backend processing and dynamically turns red/green based on the actual sandbox output instead of showing static dummy data.)