lement fully functional advanced filter drawer#154
Merged
ionfwsrijan merged 1 commit intoJun 22, 2026
Conversation
Contributor
Author
|
hi @ionfwsrijan Please review it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #152
What this PR does
This PR transforms the previously non-functional "More Filters" button into a fully working feature. Clicking the button now opens a slide-out drawer that allows users to filter the findings list by
Status(Open, Accepted, Ignored) andTool(dynamically pulled from the existing dataset).Type of change
ML tier (if applicable)
Stack affected
Changes
Backend
Frontend
frontend/src/app/pages/findings.tsx: AddedselectedStatusesandselectedToolsstate hooks. Updated thefilteredFindingsuseMemoblock to apply these filters natively on the client side. Implemented a new Radix UI<Sheet>component containing interactive<Checkbox>lists for the advanced parameters.New dependencies
Database / schema changes
Testing
How did you test this?
Tested locally by clicking the "More Filters" button, selecting different combinations of Status and Tool, and verifying that the main findings table instantly reflects the chosen parameters. Verified the "Clear All Advanced Filters" button successfully resets the state.
Checklist
console.erroror unhandled Python exceptions introducedrequirements.txt/package.jsonupdated if new dependencies added.pkl,.pt, etc.) are gitignored, not committedAnything reviewers should focus on
The filtering is handled entirely client-side within the
filteredFindingsuseMemo hook, as the full dataset is already available in memory. No additional backend endpoints were required.Screenshots (if UI changed)
(The UI now includes a right-side drawer containing multi-select checkboxes for Tool and Status filtering).