Skip to content

lement fully functional advanced filter drawer#154

Merged
ionfwsrijan merged 1 commit into
ionfwsrijan:mainfrom
lakshay122007:feat/152-functional-more-filters
Jun 22, 2026
Merged

lement fully functional advanced filter drawer#154
ionfwsrijan merged 1 commit into
ionfwsrijan:mainfrom
lakshay122007:feat/152-functional-more-filters

Conversation

@lakshay122007

Copy link
Copy Markdown
Contributor

Before opening: make sure there is an issue tracking this work, and link it below. PRs without a linked issue may be closed without review.

Linked issue

Closes #152

What this PR does

This PR transforms the previously non-functional "More Filters" button into a fully working feature. Clicking the button now opens a slide-out drawer that allows users to filter the findings list by Status (Open, Accepted, Ignored) and Tool (dynamically pulled from the existing dataset).

Type of change

  • Bug fix
  • New feature
  • ML model / training pipeline
  • Refactor (no behaviour change)
  • Documentation
  • Tests only

ML tier (if applicable)

  • Tier 1 — Triage
  • Tier 2 — Predictive
  • Tier 3 — Autonomous
  • Not ML-related

Stack affected

  • Backend
  • Frontend
  • Both

Changes

Backend

Frontend

  • frontend/src/app/pages/findings.tsx: Added selectedStatuses and selectedTools state hooks. Updated the filteredFindings useMemo block to apply these filters natively on the client side. Implemented a new Radix UI <Sheet> component containing interactive <Checkbox> lists for the advanced parameters.

New dependencies

Database / schema changes


Testing

How did you test this?

Tested locally by clicking the "More Filters" button, selecting different combinations of Status and Tool, and verifying that the main findings table instantly reflects the chosen parameters. Verified the "Clear All Advanced Filters" button successfully resets the state.

Checklist

  • Tested locally end-to-end (upload ZIP or GitHub URL → scan → findings returned correctly)
  • New ML model falls back gracefully when model file is absent
  • No new console.error or unhandled Python exceptions introduced
  • Added or updated tests where applicable
  • requirements.txt / package.json updated if new dependencies added
  • New model files (.pkl, .pt, etc.) are gitignored, not committed

Anything reviewers should focus on

The filtering is handled entirely client-side within the filteredFindings useMemo hook, as the full dataset is already available in memory. No additional backend endpoints were required.

Screenshots (if UI changed)

(The UI now includes a right-side drawer containing multi-select checkboxes for Tool and Status filtering).

Screenshot 2026-06-22 at 5 05 53 PM

@github-actions github-actions Bot added feature New feature frontend Frontend issues SSoC26 labels Jun 22, 2026
@lakshay122007

Copy link
Copy Markdown
Contributor Author

hi @ionfwsrijan Please review it. Thanks!

@ionfwsrijan ionfwsrijan added the Easy Easy difficulty label Jun 22, 2026
@ionfwsrijan ionfwsrijan merged commit 6c57a4b into ionfwsrijan:main Jun 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Easy Easy difficulty feature New feature frontend Frontend issues SSoC26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] "More Filters" Button Has No Implementation

2 participants