This repository was archived by the owner on Jul 20, 2018. It is now read-only.
Added ios_deeplinks_entitlement hook#41
Open
AlvYuste wants to merge 4 commits intoionic-team:masterfrom
AlvYuste:master
Open
Added ios_deeplinks_entitlement hook#41AlvYuste wants to merge 4 commits intoionic-team:masterfrom AlvYuste:master
AlvYuste wants to merge 4 commits intoionic-team:masterfrom
AlvYuste:master
Conversation
This was referenced Sep 4, 2017
Open
|
Hey all, just wanted to share some changes that are happening with the need for this. The new Ionic Pro Package feature doesn't require hooks to be added in here. Just install the plugin, and if there are hooks, they will Just Work. As such, I probably won't merge this just to avoid any issues with current Cloud Package. I strongly suggest taking a look at Pro which is where Ionic is going and the package service for Pro is a lot better and improving rapidly. Here's a guide on migrating over: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hook to work with ionic-plugin-deeplinks in iOS. It adds the associated domain specified to the plugin.
For instance, having:
If you include the hook:
The XCode project will have the domain
applinks:mycustomdomain.comassociated.This solves
Looking forward to a review @dwieeb.
Credits for @lpg-mac:
https://gist.github.com/lpg-mac/02abd3a77f1c880e8f9d59af4423c5af
Thanks!