Skip to content

Add notification to the middleware of peer removal. #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmiv wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add notification to the middleware of peer removal. #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27905a4
Add notification to the middleware of peer removal.
tmiv Aug 22, 2021
253755f
run gofmt
tmiv Aug 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkg/sfu/datachannel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ type (
// The datachannels created will be negotiated on join to all peers that joins
// the SFU.
Datachannel struct {
Label string
middlewares []func(MessageProcessor) MessageProcessor
onMessage func(ctx context.Context, args ProcessArgs)
Label string
middlewares []func(MessageProcessor) MessageProcessor
onMessage func(ctx context.Context, args ProcessArgs)
onRemovePeer func(peer Peer)
}

ProcessArgs struct {
Expand Down Expand Up @@ -49,6 +50,10 @@ func (dc *Datachannel) OnMessage(fn func(ctx context.Context, args ProcessArgs))
dc.onMessage = fn
}

func (dc *Datachannel) OnRemovePeer(fn func(peer Peer)) {
dc.onRemovePeer = fn
}

func (p ProcessFunc) Process(ctx context.Context, args ProcessArgs) {
p(ctx, args)
}
Expand Down
5 changes: 5 additions & 0 deletions pkg/sfu/subscriber.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ func (s *Subscriber) AddDatachannel(peer Peer, dc *Datachannel) error {
DataChannel: ndc,
})
})
ndc.OnClose(func() {
if dc.onRemovePeer != nil {
dc.onRemovePeer(peer)
}
})

s.channels[dc.Label] = ndc

Expand Down