perf: eliminate intermediate String allocation in facade log output - #2
Open
BobBinaryBuilder wants to merge 1 commit into
Open
perf: eliminate intermediate String allocation in facade log output#2BobBinaryBuilder wants to merge 1 commit into
BobBinaryBuilder wants to merge 1 commit into
Conversation
StdOut, StdErr and File facades were calling msg.to_string() to get a
heap-allocated String, then converting it to bytes for write_all, plus
a separate write_all for the newline. Replace with writeln!(handle, "{}", msg)
which formats directly into the output buffer via Display, avoiding
the intermediate allocation entirely.
Syslog is unchanged as CString inherently requires an owned buffer.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StdOut, StdErr and File facades were calling msg.to_string() to get a heap-allocated String, then converting it to bytes for write_all, plus a separate write_all for the newline. Replace with writeln!(handle, "{}", msg) which formats directly into the output buffer via Display, avoiding the intermediate allocation entirely.
Syslog is unchanged as CString inherently requires an owned buffer.
Note: This is done with claude code (opus model)