refactor: replace magic 16 with CROUCH_MAXS_Z#866
Open
WofWca wants to merge 2 commits intoioquake:mainfrom
Open
refactor: replace magic 16 with CROUCH_MAXS_Z#866WofWca wants to merge 2 commits intoioquake:mainfrom
CROUCH_MAXS_Z#866WofWca wants to merge 2 commits intoioquake:mainfrom
Conversation
This is a follow-up to 38c4180 (ioquake#828). This is not really "height" because height is constituted by `maxs[2] - mins[2]`. So the new name should be in line with the existing variable named `MINS_Z`.
Two lines below we set "ducked" and "crouch", so this confirms the intentions to use `CROUCH_MAXS_Z` for `maxs[2]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two lines below we set "ducked" and "crouch",
so this confirms the intentions to use
CROUCH_MAXS_Zfor
maxs[2].This MR is based on #856. Can be merged right away, thus merging 2 MRs at a time.