feat: rework deployStylusCode to use StylusDeployer contract#3
Open
bernard-wagner wants to merge 3 commits intomasterfrom
Open
feat: rework deployStylusCode to use StylusDeployer contract#3bernard-wagner wants to merge 3 commits intomasterfrom
bernard-wagner wants to merge 3 commits intomasterfrom
Conversation
99bf8c6 to
a8f8a66
Compare
Replace the 3-step internal approach (exec_create + activate_program + exec_call constructor) with a single exec_call to the StylusDeployer contract, which atomically deploys, activates via ARB_WASM, and calls the constructor. This produces a single CALL transaction when broadcasting, ensuring on-chain replay deploys a fully activated contract. Key changes: - Add StylusDeployer address and runtime code constants - Add deploy_stylus_deployer() to executor setup (test + script) - Add call_from_code flag on Broadcast struct for capturing cheatcode-internal exec_call as broadcastable CALL - Simulate with 1 ETH activation budget, temporarily clear caller code for refund, compute actual fee from balance diff, adjust broadcast tx value with 20% buffer
a8f8a66 to
f12d858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the 3-step internal approach (exec_create + activate_program + exec_call constructor) with a single exec_call to the StylusDeployer contract, which atomically deploys, activates via ARB_WASM, and calls the constructor. This produces a single CALL transaction when broadcasting, ensuring on-chain replay deploys a fully activated contract.
Key changes: