Don't disable default features of form_urlencoded

[madsmtm]

Description of change

In servo/rust-url#722, we would like to make the crate potentially not need alloc in the future, but to do so, we must now introduce a required alloc feature.

Since this project uses default-features = false on form_urlencoded (which previously did nothing), it will break once that change lands.

Links to any relevant issues

Also requires l1h3r/did_url#2 to land (since this crate depends on did_url).

Type of change

• Bug fix (a non-breaking change which fixes an issue)
• Enhancement (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Fix

How the change has been tested

N/A

Change checklist

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[eike-hass]

Hi @madsmtm 👋 Thank you for taking the time to open this PR and the consideration, we appreciate it!
Regarding l1h3r/did_url#2: We are considering forking the repository moving forward, since there has been no activity for the last years. In that case we would also adopt the default-features change in the fork.

[madsmtm]

Regarding l1h3r/did_url#2: We are considering forking the repository moving forward, since there has been no activity for the last years. In that case we would also adopt the default-features change in the fork.

That's understandable - you're free to do so however you wish btw (e.g. I don't need the git attribution).

[eike-hass]

Hi 👋 @madsmtm Would you be able to sign your commit?

[madsmtm]

Hmm, I quickly tried to do so but it seems it'll take me some more time to understand how git signing works first :/

I'd be fine with you / someone else just doing an empty rebase and pushing to my fork, or whatever works.

[eike-hass]

Hmm, I quickly tried to do so but it seems it'll take me some more time to understand how git signing works first :/

I'd be fine with you / someone else just doing an empty rebase and pushing to my fork, or whatever works.

No problem 👌 We will do the change in #1136 and close this PR.