Skip to content

refactor(agent): extract nested science experts#316

Merged
JaimeCernuda merged 1 commit into
developfrom
feat/child-science-experts-20260523
May 24, 2026
Merged

refactor(agent): extract nested science experts#316
JaimeCernuda merged 1 commit into
developfrom
feat/child-science-experts-20260523

Conversation

@JaimeCernuda
Copy link
Copy Markdown
Collaborator

Summary

  • extract executable NDPExpert and SACFormatExpert child expert classes
  • register the nested experts as real dispatch targets instead of compatibility aliases through Data/Analysis
  • keep Data/Analysis as top-level managers that delegate NDP/SAC work through child experts
  • update tests to assert top-level tool lists no longer directly own NDP/SAC tools
  • record the completed extraction and remaining shared-model caveat in TASK.md

Verification

  • uv run ruff check src/ tests/ scripts/create_demo_data.py
  • uv run pytest tests/test_core/test_agent_planner.py::TestBuildCapabilitiesContext tests/test_core/test_agent_planner.py::TestRunAgentLoop::test_ndp_tool_action_is_promoted_to_nested_catalog_expert tests/test_core/test_agent_dispatch.py tests/test_gact/test_agents_catalog.py tests/test_tools/test_ndp_server.py tests/test_tools/test_sac_server.py tests/test_experts/test_analysis_expert.py tests/test_experts/test_data_expert.py -q (106 passed)
  • uv run pytest tests/ -q (1152 passed, 37 skipped, 81% coverage)

@JaimeCernuda JaimeCernuda merged commit a38f519 into develop May 24, 2026
1 check failed
@JaimeCernuda JaimeCernuda deleted the feat/child-science-experts-20260523 branch May 24, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant