feat(agent): give chat scoped utility tools#321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chatintools/catalog.py; scientific tools remain behind their owning experts._execute_tool_action()so permission checks, trace recording, tool telemetry, and expert handoff metadata stay on the normal CLIO path.date,get-date,pwd,whoami,hostname) while keeping arbitrary shell gated/denied without a no-session 120s permission wait.TASK.mdwith live ALCF evidence for the slice.Verification
uv run ruff check --fix src/clio_agent/agent.py src/clio_agent/gact/app.py src/clio_agent/signatures/main_agent_sig.py tests/test_core/test_agent_planner.py tests/test_gact/test_permission_gate.pyuv run ruff format src/clio_agent/agent.py src/clio_agent/gact/app.py src/clio_agent/signatures/main_agent_sig.py tests/test_core/test_agent_planner.py tests/test_gact/test_permission_gate.pyuv run pytest tests/test_gact/test_permission_gate.py::test_builtin_shell_tool_allows_safe_diagnostic_command tests/test_gact/test_permission_gate.py::test_builtin_shell_tool_still_gates_non_diagnostic_command -q->2 passeduv run pytest tests/test_core/test_agent_planner.py::TestChatAgentNoBypass tests/test_core/test_agent_dispatch.py tests/test_gact/test_permission_gate.py -q->52 passeduv run pytest tests/->1162 passed, 37 skippedgpt-oss-120bGACT check onhttp://127.0.0.1:17966,routing_mode=chat, prompt:What is the current time on this machine? Please answer using the local utility tool.Result:error_info=null, selected route partchat, one visibleshell_bash(date)call withok=true, stdoutSunday, May 24, 2026 1:11:11 AM, andutilitydirect-tool handoffsuccess.