Demote DumpNetStats HLOGs to kDebug#425
Merged
1 commit merged intoMay 21, 2026
Merged
Conversation
These two HLOG lines in DumpNetStatsIfDue fire once per second under the periodic-stats timer (kNetStatsDumpIntervalSec = 1.0) and clutter normal-verbosity logs with NetStats counters that are only useful when actively profiling cross-node traffic. Closes #424
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context-runtime/modules/admin/src/admin_runtime.cc:140and:166:HLOG(kInfo, ...)→HLOG(kDebug, ...).Motivation
Closes #424.
DumpNetStatsIfDuefires once per second underkNetStatsDumpIntervalSec = 1.0and the two[NetStats]lines (per-peer + TOTAL) flood normal-verbosity logs. Useful when profiling cross-node traffic but not at default verbosity.Test plan
grep 'HLOG(kInfo' admin_runtime.ccno longer hits lines 140/166Breaking changes
None — strictly a verbosity reduction.