[NFC] Remove the llvm-external-projects/iree-dialects directory (#24466)#24612
Open
Alex-Wengg wants to merge 2 commits into
Open
[NFC] Remove the llvm-external-projects/iree-dialects directory (#24466)#24612Alex-Wengg wants to merge 2 commits into
Alex-Wengg wants to merge 2 commits into
Conversation
…4466) All production code paths that depended on iree-dialects have been retired (iree-org#24543 and predecessors): the softmax matcher and ErrorCheckingTrackingListener were reimplemented in-tree, DropSchedulePass was moved into Codegen/Common, and the callback-matcher transform ops and their tests were dropped. Nothing in the compiler or runtime references iree-dialects any longer. This removes the now-empty shell directory and unwires it from the build: - delete llvm-external-projects/iree-dialects/ (standalone iree-dialects-opt tool, Python bindings, lit test harness, build files) - drop the iree_llvm_add_external_project(mlir-iree-dialects ...) call in the top-level CMakeLists.txt - remove the dead iree-dialects target conversion from bazel_to_cmake - drop the IREEDialects* Python sources and include path from the compiler Python bindings, and the iree_dialects.rst API doc - remove the iree-dialects-doc build step from the website doc generator - remove the "Test iree-dialects" CI steps and the check-iree-dialects targets from the ASan/UBSan scripts (and the now-unused test_iree_dialects.sh) - drop the CODEOWNERS, .gitignore, and README references Signed-off-by: Alex-Wengg <hanweng9@gmail.com>
Alex-Wengg
requested review from
Groverkss,
MaheshRavishankar,
ScottTodd,
amd-eochoalo,
benvanik and
kuhar
as code owners
Alex-Wengg
changed the title
Alex-Wengg
force-pushed
the
retire-iree-dialects-final
branch
from
23d73e0 to
108dadf
Compare
compiler/setup.py still declared the iree.compiler._mlir_libs._ireeDialects
CMakeExtension after this PR removed the sources that built it. With
IREE_BUILD_PYTHON_BINDINGS=ON the wheel build iterates ext_modules and tries
to link _ireeDialects with no inputs, so gcc fails ("no input files") and the
iree-base-compiler wheel build errors out. Remove the dead extension entry.
Signed-off-by: Alex-Wengg <hanweng9@gmail.com>
Alex-Wengg
force-pushed
the
retire-iree-dialects-final
branch
from
108dadf to
e11559a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Removes the
llvm-external-projects/iree-dialectsdirectory now that nothing in the compiler or runtime depends on it.This is the final step of #24466. The production dependencies were retired in #24543 and predecessors:
GlobalOptimization/RaiseSpecialOps,ErrorCheckingTrackingListenerwas moved intoCodegen/Common/,DropSchedulePasswas moved intoCodegen/Common/,transform.iree.register_match_callbacks/match_callback/take_first/emit_remark) and their tests were dropped.Changes
llvm-external-projects/iree-dialects/.iree_llvm_add_external_project(mlir-iree-dialects ...)call from the top-levelCMakeLists.txt.bazel_to_cmake.IREEDialects*Python sources + include path fromcompiler/bindings/python/CMakeLists.txt, the_ireeDialectsCMakeExtensionfromcompiler/setup.py, and theiree_dialects.rstAPI doc.iree-dialects-docbuild step from the website doc generator.check-iree-dialectstargets from the ASan/UBSan scripts (and the now-unusedtest_iree_dialects.sh).Testing
stablehloremains as an external LLVM project and a full-tree grep finds zero dangling references. The fulliree-opttarget builds, links, and runs (iree-opt --version→ LLVM 23.0.0git).