Skip to content

Fix strict aliasing warnings. - #1

Open
QuLogic wants to merge 1 commit into
iris-edu:masterfrom
QuLogic:strict-aliasing
Open

Fix strict aliasing warnings.#1
QuLogic wants to merge 1 commit into
iris-edu:masterfrom
QuLogic:strict-aliasing

Conversation

@QuLogic

@QuLogic QuLogic commented Jun 8, 2017

Copy link
Copy Markdown

TBH, I wrote this quite a while ago when packaging this, so I don't quite remember everything. It fixes warnings like the following, though I think it might use some GCCisms:

mars2mseed.c: In function 'mars2group':
mars2mseed.c:238:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   mbGetStationCode(hMS->block), mbGetChan(hMS->block),
   ^~~~~~~~~~~~~~~~
mars2mseed.c:239:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   mbGetSampRate(hMS->block), mbGetScale(hMS->block),
   ^~~~~~~~~~~~~
mars2mseed.c:239:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
mars2mseed.c:240:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   mbGetTime(hMS->block),
   ^~~~~~~~~
mars2mseed.c:240:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
mars2mseed.c:240:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
mars2mseed.c:241:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   marsBlockGetScaleFactor(hMS->block), mbGetMaxamp(hMS->block));
   ^~~~~~~~~~~~~~~~~~~~~~~
mars2mseed.c:278:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    msr->samprate = mbGetSampRate(hMS->block);
    ^~~
mars2mseed.c:279:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    msr->starttime = MS_EPOCH2HPTIME (mbGetTime(hMS->block));
    ^~~
mars2mseed.c:279:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
mars2mseed.c:279:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
mars2mseed.c:295:5: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     if ( *(clp->key) == ('0' + (int)mbGetChan(hMS->block)) )
     ^~
mars2mseed.c:308:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    transmatrix[transchan][(int)mbGetChan(hMS->block)]);
    ^~~~~~~~~~~
mars2mseed.c:313:8: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
        snprintf (msr->channel, 10, "%d", mbGetChan(hMS->block));
        ^~~~~~~~
mars2mseed.c:317:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    if ( mbGetBlockFormat(hMS->block) == DATABLK_FORMAT )
    ^~
mars2mseed.c:318:6: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
      if ( ((m88Head *)(hMS->block))->time.delta != NO_WORD )
      ^~
mars2mseed.c:320:9: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
         ((m88Head *)(hMS->block))->time.delta,
         ^
marsio.c: In function 'marsStreamGetNextBlock':
marsio.c:430:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
       if ( mbGetMagic(MS.block) == LEMAGICbe )
       ^~
marsio.c:431:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  switch ( ((leFormat *) &(MS.block))->block_format )
  ^~~~~~
marsio.c:447:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   mbGetMagic(MS.block),mbGetBlockFormat(MS.block),mbGetDataFormat(MS.block),
   ^~~~~~~~~~
marsio.c:447:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
marsio.c:447:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
marsio.c:448:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
   mbGetChan(MS.block));
   ^~~~~~~~~
marsio.c:450:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
       if ( isMarsDataBlock(MS.block) && mbGetChan(MS.block) < 3 )
       ^~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant