Fix requesting a parsed URL object (node.js 'request' compatibility)#44
Open
deathcap wants to merge 1 commit intoiriscouch:masterfrom
Open
Fix requesting a parsed URL object (node.js 'request' compatibility)#44deathcap wants to merge 1 commit intoiriscouch:masterfrom
deathcap wants to merge 1 commit intoiriscouch:masterfrom
Conversation
The Node 'request' module allows options.uri to be a parsed object from the 'url' module. In this case, the href property is set to the original URL. Check for this property to restore compatibility with browser-request/request.
deathcap
added a commit
to deathcap/webnpm
that referenced
this pull request
Feb 9, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node 'request' module allows options.uri to be a parsed object
from the 'url' module. In this case, the href property is set to
the original URL. Check for this property to restore compatibility
with browser-request/request.
e.g., this code works in node:
and now works with a browserified browser-request. Includes test case