feat: added parsed headers to response object#71
Open
adampash wants to merge 1 commit intoiriscouch:masterfrom
Open
feat: added parsed headers to response object#71adampash wants to merge 1 commit intoiriscouch:masterfrom
adampash wants to merge 1 commit intoiriscouch:masterfrom
Conversation
|
Thanks for this. Shame the PR hasn't been merged but I'm using your fork for now. |
|
@iriscouch is this likely to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this is something you're interested in adding, but I needed the response headers in the response, and this PR adds them. It also adds another dependency, which you might not want.
Anyway, I am using browser-request for a node/web project, and it's been great! I just needed this one adjustment to make it compatible with the response object from node request.
Thanks!
(Oh also, apologies for the semi-colon stuff. I can clean that up if you wanted to merge this.)