Open
Conversation
The 65 HTTPS record in particular is now frequently requested by Chrome and without this mapping defined an error is thrown.
If an error is thrown while creating a Request object, such as when an unknown resource record type is requested, there's no way for the client to handle it. The error is thrown before the request is emitted and the handler is called. This change leaves the underlying error throwing as it is but catches the error in the server and emits them instead.
Any errors that might be emitted from the socket rather than the server can't be handled by the client. This listens for errors on the connection (and request and response) and emits them from the server. In order to do that, the Request and Response objects (which inherit from DNSMessage) must actually be EventEmitters. They often call emit, but only in rare code paths. Those code paths would throw because emit wasn't a function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CAA record support to DNSD. This will help with CA validation.
The record seems to be an 8-bit flag, then an 8-bit length of the type, followed by the payload (type and value).
Values generated by this have been validated by using https://sslmate.com/caa/ and
dig 9.9.7-P3Usage:
To get
0 issuewild "digicert.com"to show up on your DNS records, you should use:Fixes #19