Creating a file to exec shell scripts#129
Open
caioreis wants to merge 1 commit intoiron-meteor:masterfrom
Open
Creating a file to exec shell scripts#129caioreis wants to merge 1 commit intoiron-meteor:masterfrom
caioreis wants to merge 1 commit intoiron-meteor:masterfrom
Conversation
Contributor
|
What happens if someone is on windows? Also, could we not put shell logic into env.sh instead of a separate file? |
Author
|
@cmather, It is true, if someone is on windows this will fail. Is there any iron-cli current feature that works different when we switch the OS? About the shell logic, I would use a different file to organize. It does not make sense to me to source env variables in the same file that I pull a repository, but I can be wrong. How to decide that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to issue #94, support for bash script before running.