BER Webdev PT 012024 Nil Erden#2997
Open
nil-e wants to merge 4 commits into
Open
Conversation
jacked97
suggested changes
Mar 26, 2024
| return productData; | ||
| }) | ||
| .then(() => { | ||
| for (let i = 0; i < 25; i++) { |
There was a problem hiding this comment.
- avoid for loop with let i =0 sync, here you have define the length everytime. (use better available options .forEach, for(const each of array)
| } | ||
| return itemNames; | ||
| }) | ||
| .then(() => res.render('beers', { itemNames })) |
There was a problem hiding this comment.
when you returning in previous .then() you can just receive it as parameter, there is no need of using itemNames variable to store it (unless needed) [Promise Chaining]
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried doing the lab I found out that the PunkAPI is down and it will be decommissioned soon as well. So I used another api to get product data. So i am not really displaying beers but it should follow the same logic.