Skip to content

BCN 0419 - Jason #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JasonCB083 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BCN 0419 - Jason #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions apple-pie-starter-code/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
body {
font-family: 'Roboto', sans-serif;
font-weight: 300;
}

header {
background-image: url("/Users/jasoncuellar/code/labs/lab-css-recipes-clone/apple-pie-starter-code/images/apple-pie.jpg");
background-position: 0 0;
background-repeat: no-repeat;
background-size: cover;
line-height: 450px;
text-align: center;
}

ul {
list-style-type: none;
}

h1 {
color: white;
font-size: 65px;
font-family: 'Roboto', sans-serif;
font-weight: 400;
}

.container {
margin: 0 120px 0;

}
.images-center1 {

padding: 10px 170px 10px;
height: 60px;
}
.images-center2 {

padding: 10px 180px 10px 180px;

@tawebbcn tawebbcn Apr 4, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that you can use the shorthand: padding: 10px 180px;

height: 60px;
}
.image-container {
text-align: center;
}
93 changes: 63 additions & 30 deletions apple-pie-starter-code/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,68 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Apple Pie Recipe</title>
</head>
<body>
Apple Pies
This was my grandmother's apple pie recipe. I have never seen another one
quite like it. It will always be my favorite and has won me several first place
prizes in local competitions. I hope it becomes one of your favorites as well!
<head>
<title>Apple Pie Recipe</title>
<link rel="stylesheet" href="./css/main.css">
<link href="https://fonts.googleapis.com/css?family=Roboto:300,400" rel="stylesheet">
</head>

Ingredients
1 recipe pastry for a 9 inch double crust pie
1/2 cup unsalted butter
3 tablespoons all-purpose flour
1/4 cup water
3 tablespoons all-purpose flour
1/4 cup water
1/2 cup white sugar
1/2 cup packed brown sugar
8 Granny Smith apples - peeled, cored and sliced
<body>
<header>
<h1>Apple Pies</h1>
</header>

@tawebbcn tawebbcn Apr 4, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have a general structure for the html like:

<header></header>
<main></main>
<footer></footer>

As general layout. Maybe this exercise had no footer but definitely a main tag


<div class="container">
<section>
<div>

@tawebbcn tawebbcn Apr 4, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you need this div :)

<p>
This was my grandmother's apple pie recipe. I have never seen another one
quite like it. It will always be my favorite and has won me several first place
prizes in local competitions. I hope it becomes one of your favorites as well!
</p>
</div>
</section>

Directions
Preheat oven to 425 degrees F (220 degrees C). Melt the butter in a saucepan. Stir in
flour to form a paste. Add water, white sugar and brown sugar, and bring to a boil. Reduce
temperature and let simmer.

Place the bottom crust in your pan. Fill with apples, mounded slightly. Cover with a
lattice work crust. Gently pour the sugar and butter liquid over the crust. Pour slowly so
that it does not run off.

Bake 15 minutes in the preheated oven. Reduce the temperature to 350 degrees F (175
degrees C). Continue baking for 35 to 45 minutes, until apples are soft.
</body>
<section>
<div class="image-container">
<img src="/Users/jasoncuellar/code/labs/lab-css-recipes-clone/apple-pie-starter-code/images/recipe-info.png" alt="recipe info " class="images-center1">
</div>
</section>
<hr>

@tawebbcn tawebbcn Apr 4, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to us hr for styling. If you need a space do it with CSS better. Best practice is separation of concerns. HTML only structure and content, CSS only styling.

<section>
<div class="ingredients">
<p>

@tawebbcn tawebbcn Apr 4, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This p doesn't make sense here. A ptag is for paragraphs.

<h2> <b>Ingredients</b></h2>
<ul>
<li>-1 recipe pastry for a 9 inch double crust pie</li>
<li>-1/2 cup unsalted butter</li>
<li>-3 tablespoons all-purpose flour</li>
<li>-1/4 cup water</li>
<li>-3 tablespoons all-purpose flour</li>
<li>-1/4 cup water</li>
<li>-1/2 cup white sugar</li>
<li>-1/2 cup packed brown sugar</li>
<li>-8 Granny Smith apples - peeled, cored and sliced</li>
</ul>
</p>
</div>
</section>
<div class="image-container">
<img src="/Users/jasoncuellar/code/labs/lab-css-recipes-clone/apple-pie-starter-code/images/cooking-info.png" alt="cooking info" class="images-center2">
</div>
<hr>
<section>
<div class="directions">
<h2>Directions</h2>
<ol>
<li>Preheat oven to 425 degrees F (220 degrees C). Melt the butter in a saucepan. Stir in flour to form a paste. Add water, white sugar and brown sugar, and bring to a boil. Reduce temperature and let simmer.</li>
<li>Place the bottom crust in your pan. Fill with apples, mounded slightly. Cover with a lattice work crust. Gently pour the sugar and butter liquid over the crust. Pour slowly so that it does not run off.</li>
<li>
Bake 15 minutes in the preheated oven. Reduce the temperature to 350 degrees F (175
degrees C). Continue baking for 35 to 45 minutes,until apples are soft.
</li>
</ol>
</div>
</section>
</div>
</body>
</html>
48 changes: 46 additions & 2 deletions french-onion-soup-starter-code/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,53 @@
/*Some necessary adjustments*/
/* Some necessary adjustments
h1, body, html, main {
margin: 0;
}
/*Import the font and set the default size*/
html {
/* html {
font-family: 'Open Sans', sans-serif;
font-size: 18px
} */

body {
font-family: 'Roboto', sans-serif;
font-weight: 300;
}

header {
background-image: url("/Users/jasoncuellar/code/labs/lab-css-recipes-clone/french-onion-soup-starter-code/images/soup.jpg");
background-position: 0 0;
background-repeat: no-repeat;
background-size: cover;
line-height: 450px;
text-align: center;
}

ul {
list-style-type: none;
}

h1 {
color: white;
font-size: 65px;
font-family: 'Roboto', sans-serif;
font-weight: 400;
}

.container {
margin: 0 120px 0;

}
.images-center1 {

padding: 10px 170px 10px;
height: 60px;
}
.images-center2 {

padding: 10px 180px 10px 180px;
height: 60px;
}
.image-container {
text-align: center;
}

112 changes: 74 additions & 38 deletions french-onion-soup-starter-code/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,79 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>French Onion Soup Recipe</title>
<!-- Google fonts gives us access to the Open Sans Font -->
<!-- Google fonts is also awesome! Make sure to check it out -->
<link href="https://fonts.googleapis.com/css?family=Open+Sans:300,600" rel="stylesheet">
</head>
<body>
French Onion Soup
<head>
<title>French Onion Soup Recipe</title>
<link rel="stylesheet" href="./css/main.css">
<link href="https://fonts.googleapis.com/css?family=Roboto:300,400" rel="stylesheet">
</head>

We have been trying French onion soup in restaurants for years and my family
and friends agree none can compare to my recipe for taste and simplicity of
preparation.
<body>
<header>
<h1>French Onion Soup</h1>
</header>

<div class="container">
<section>
<div>

@tawebbcn tawebbcn Apr 4, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with indentation. Something happened here, is different from the previous exercise

<p>
We have been trying French onion soup in restaurants for years and my family
and friends agree none can compare to my recipe for taste and simplicity of
preparation.
</p>
</div>
</section>

Ingredients
1/2 cup unsalted butter
2 tablespoons olive oil
4 cups sliced onions
4 (10.5 ounce) cans beef broth
2 tablespoons dry sherry (optional)
1 teaspoon dried thyme
salt and pepper to taste
4 slices French bread
4 slices provolone cheese
2 slices Swiss cheese, diced
1/4 cup grated Parmesan cheese

Directions
Melt butter with olive oil in an 8 quart stock pot on medium heat. Add onions and
continually stir until tender and translucent. Do not brown the onions.

Add beef broth, sherry and thyme. Season with salt and pepper, and simmer for 30
minutes.

Heat the oven broiler.

Ladle soup into oven safe serving bowls and place one slice of bread on top of each
(bread may be broken into pieces if you prefer). Layer each slice of bread with a slice of
provolone, 1/2 slice diced Swiss and 1 tablespoon Parmesan cheese. Place bowls on
cookie sheet and broil in the preheated oven until cheese bubbles and browns slightly.
</body>
<section>
<div class="image-container">
<img src="/Users/jasoncuellar/code/labs/lab-css-recipes-clone/french-onion-soup-starter-code/images/recipe-info.png" alt="recipe info " class="images-center1">
</div>
</section>
<hr>
<section>
<div class="ingredients">
<p>
<h2> <b>Ingredients</b></h2>
<ul>
<li>-1/2 cup unsalted butter</li>
<li>-12 tablespoons olive oil</li>
<li>-4 cups sliced onions</li>
<li>-4 (10.5 ounce) cans beef broth</li>
<li>-2 tablespoons dry sherry (optional)</li>
<li>-1 teaspoon dried thyme</li>
<li>-salt and pepper to taste</li>
<li>-4 slices French bread</li>
<li>-4 slices provolone cheese</li>
<li>-2 slices Swiss cheese, diced</li>
<li>-1/4 cup grated Parmesan cheese</li>
</ul>
</p>
</div>
</section>
<div class="image-container">
<img src="/Users/jasoncuellar/code/labs/lab-css-recipes-clone/french-onion-soup-starter-code/images/cooking-info.png" alt="cooking info" class="images-center2">
</div>
<hr>
<section>
<div class="directions">
<h2>Directions</h2>
<ol>
<li>

@tawebbcn tawebbcn Apr 4, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation! li should be inside ```ul````

Add beef broth, sherry and thyme. Season with salt and pepper, and simmer for 30
minutes.
</li>
<li>
Add beef broth, sherry and thyme. Season with salt and pepper, and simmer for 30
minutes.
</li>
<li>Heat the oven broiler.</li>
<li>
Ladle soup into oven safe serving bowls and place one slice of bread on top of each
(bread may be broken into pieces if you prefer). Layer each slice of bread with a slice of
provolone, 1/2 slice diced Swiss and 1 tablespoon Parmesan cheese. Place bowls on
cookie sheet and broil in the preheated oven until cheese bubbles and browns slightly.
</li>
</ol>
</div>
</section>
</div>
</body>
</html>