Skip to content

BCN-0419 Jesus Cebader #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zebader wants to merge 4 commits into
base: master
Choose a base branch
from
Open

BCN-0419 Jesus Cebader #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
461f887
add header bg and h1
zebader Apr 1, 2019
0881600
add intro and ingredients section
zebader Apr 1, 2019
07a99b3
add directions sections - finish apple pies
zebader Apr 1, 2019
b8b37d1
add french soup website and fixing classes - end
zebader Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions apple-pie-starter-code/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
@import url('https://fonts.googleapis.com/css?family=Roboto:200,400,900');

*{
margin: 0px;
padding: 0px;
font-family: 'Roboto', sans-serif;
font-weight: 400;
font-size: 24px;
color:#4d4d4d;
}

.hero-header{
position: relative;
width: 100%;
height: 100vh;
background:url(../images/apple-pie.jpg);
background-size: cover;
}
#hero-header-french{
position: relative;
width: 100%;
height: 100vh;
background:url(../../french-onion-soup-starter-code/images/soup.jpg);
background-size: cover;
}

.hero-header header{
position:relative;
top: 50%;
transform:translateY(-50%);
}
.hero-header header h1{
font-size: 7vw;

@tawebbcn tawebbcn Apr 2, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responsive typography is a hard thing, try to use fixed units for typography and not relative units.

text-align:center;
color: white;
}
main{
position: relative;
width: 100%;
max-width: 1310px;
left: 50%;
transform:translateX(-50%);
}
#intro{
position: relative;
width: 100%;
}
#intro article{
position: relative;
width: 80%;
left: 50%;
transform:translateX(-50%);
padding: 5% 0px;
}
#intro article p{
text-align: justify;
font-weight: 200;
}
#intro article img{
position: relative;
left: 50%;
transform: translateX(-50%);
margin: 3% 0px;
width: 80%;
max-width: 480px;
}

#ingredients, #directions{
position: relative;
width: 80%;
left: 50%;
transform:translateX(-50%);
padding-bottom: 5%;
}
#ingredients header h2, #directions header h2{

@tawebbcn tawebbcn Apr 2, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to keep it as simple as possible, I think in this case for example if you target this rulo only with h2 should work as well:

h2 {
  font-size: 1em;
  padding-bottom: 2.5%;
  font-weight: 400;
  color: black;
}

font-size: 1em;
padding-bottom: 2.5%;
font-weight: 400;
color: black;
}
#ingredients ul li{

@tawebbcn tawebbcn Apr 2, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, you only have one ul so you don't need to add the #ingredients selector

list-style: none;
font-size: 0.8em;
}
#ingredients article img{
position: relative;
left: 50%;
transform: translateX(-50%);
margin: 3% 0px;
width: 80%;
max-width: 480px;
}
#directions ol li{
list-style: none;
font-size: 0.8em;
}
77 changes: 54 additions & 23 deletions apple-pie-starter-code/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,65 @@
<html lang="en">
<head>
<title>Apple Pie Recipe</title>
<link rel="stylesheet" href="./css/main.css">
</head>
<body>
Apple Pies
This was my grandmother's apple pie recipe. I have never seen another one
quite like it. It will always be my favorite and has won me several first place
prizes in local competitions. I hope it becomes one of your favorites as well!
<section class="hero-header">

@tawebbcn tawebbcn Apr 2, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should revise the structure of the html in general. You should have this as basic structure:

<header></header>
<main></main>
<footer></footer>

Instead of having multiple headers insides sections that are inside the main
If you have any questions about this please let us know

<header>
<h1>Apple Pies</h1>
</header>
</section>
<main>
<section id="intro">
<article>
<p>This was my grandmother's apple pie recipe. I have never seen another one
quite like it. It will always be my favorite and has won me several first place
prizes in local competitions. I hope it becomes one of your favorites as well!</p>
<img src="./images/recipe-info.png">
<hr/>
</article>
</section>

Ingredients
1 recipe pastry for a 9 inch double crust pie
1/2 cup unsalted butter
3 tablespoons all-purpose flour
1/4 cup water
3 tablespoons all-purpose flour
1/4 cup water
1/2 cup white sugar
1/2 cup packed brown sugar
8 Granny Smith apples - peeled, cored and sliced
<section id="ingredients">
<header>
<h2>Ingredients</h2>
</header>
<article>
<ul>
<li>- 1 recipe pastry for a 9 inch double crust pie</li>
<li>- 1/2 cup unsalted butter</li>
<li>- 3 tablespoons all-purpose flour</li>
<li>- 1/4 cup water</li>
<li>- 3 tablespoons all-purpose flour</li>
<li>- 1/4 cup water</li>
<li>- 1/2 cup white sugar</li>
<li>- 1/2 cup packed brown sugar</li>
<li>- 8 Granny Smith apples - peeled, cored and sliced</li>
</ul>
<img src="./images/cooking-info.png">

@tawebbcn tawebbcn Apr 2, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the alt attribute, it is always best practice to add it

<hr/>
</article>
</section>

Directions
Preheat oven to 425 degrees F (220 degrees C). Melt the butter in a saucepan. Stir in
flour to form a paste. Add water, white sugar and brown sugar, and bring to a boil. Reduce
temperature and let simmer.
<section id="directions">
<header>
<h2>Directions</h2>
</header>
<article>
<ol>
<li>1) Preheat oven to 425 degrees F (220 degrees C). Melt the butter in a saucepan. Stir in
flour to form a paste. Add water, white sugar and brown sugar, and bring to a boil. Reduce
temperature and let simmer.</li>

Place the bottom crust in your pan. Fill with apples, mounded slightly. Cover with a
lattice work crust. Gently pour the sugar and butter liquid over the crust. Pour slowly so
that it does not run off.
<li>2) Place the bottom crust in your pan. Fill with apples, mounded slightly. Cover with a
lattice work crust. Gently pour the sugar and butter liquid over the crust. Pour slowly so
that it does not run off.</li>

Bake 15 minutes in the preheated oven. Reduce the temperature to 350 degrees F (175
degrees C). Continue baking for 35 to 45 minutes, until apples are soft.
<li>3) Bake 15 minutes in the preheated oven. Reduce the temperature to 350 degrees F (175
degrees C). Continue baking for 35 to 45 minutes, until apples are soft.</li>
</ol>
</article>
</section>
</main>
</body>
</html>
92 changes: 57 additions & 35 deletions french-onion-soup-starter-code/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,65 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>French Onion Soup Recipe</title>
<!-- Google fonts gives us access to the Open Sans Font -->
<!-- Google fonts is also awesome! Make sure to check it out -->
<link href="https://fonts.googleapis.com/css?family=Open+Sans:300,600" rel="stylesheet">
</head>
<body>
French Onion Soup
<head>
<title>French Onion Soup Recipe</title>
<!-- Google fonts gives us access to the Open Sans Font -->
<!-- Google fonts is also awesome! Make sure to check it out -->
<link href="https://fonts.googleapis.com/css?family=Open+Sans:300,600" rel="stylesheet">
<link rel="stylesheet" href="../apple-pie-starter-code/css/main.css">
</head>
<body>
<section class="hero-header" id="hero-header-french">
<header>
<h1>French Onion Soup</h1>
</header>
</section>
<main>
<section id="intro">
<article>
<p>We have been trying French onion soup in restaurants for years and my family and friends agree none can compare to my recipe for taste and simplicity of preparation.</p>
<img src="./images/recipe-info.png">
<hr/>
</article>
</section>

We have been trying French onion soup in restaurants for years and my family
and friends agree none can compare to my recipe for taste and simplicity of
preparation.
<section id="ingredients">
<header>
<h2>Ingredients</h2>
</header>
<article>
<ul>
<li>- 1/2 cup unsalted butter</li>
<li>- 2 tablespoons olive oil</li>
<li>- 4 cups sliced onions</li>
<li>- 4 (10.5 ounce) cans beef broth</li>
<li>- 2 tablespoons dry sherry (optional)</li>
<li>- 1 teaspoon dried thyme</li>
<li>- salt and pepper to taste</li>
<li>- 4 slices French bread</li>
<li>- 4 slices provolone cheese</li>
<li>- 2 slices Swiss cheese, diced</li>
<li>- 1/4 cup grated Parmesan cheese</li>
</ul>
<img src="./images/cooking-info.png">
<hr/>
</article>
</section>

Ingredients
1/2 cup unsalted butter
2 tablespoons olive oil
4 cups sliced onions
4 (10.5 ounce) cans beef broth
2 tablespoons dry sherry (optional)
1 teaspoon dried thyme
salt and pepper to taste
4 slices French bread
4 slices provolone cheese
2 slices Swiss cheese, diced
1/4 cup grated Parmesan cheese
<section id="directions">
<header>
<h2>Directions</h2>
</header>
<article>
<ol>
<li>1) Melt butter with olive oil in an 8 quart stock pot on medium heat. Add onions and continually stir until tender and translucent. Do not brown the onions.</li>

Directions
Melt butter with olive oil in an 8 quart stock pot on medium heat. Add onions and
continually stir until tender and translucent. Do not brown the onions.
<li>2) Add beef broth, sherry and thyme. Season with salt and pepper, and simmer for 30 minutes.</li>

Add beef broth, sherry and thyme. Season with salt and pepper, and simmer for 30
minutes.

Heat the oven broiler.

Ladle soup into oven safe serving bowls and place one slice of bread on top of each
(bread may be broken into pieces if you prefer). Layer each slice of bread with a slice of
provolone, 1/2 slice diced Swiss and 1 tablespoon Parmesan cheese. Place bowls on
cookie sheet and broil in the preheated oven until cheese bubbles and browns slightly.
<li>3) Heat the oven broiler.</li>
<li>3) Ladle soup into oven safe serving bowls and place one slice of bread on top of each(bread may be broken into pieces if you prefer). Layer each slice of bread with a slice of provolone, 1/2 slice diced Swiss and 1 tablespoon Parmesan cheese. Place bowls on cookie sheet and broil in the preheated oven until cheese bubbles and browns slightly.</li>
</ol>
</article>
</section>
</main>

@tawebbcn tawebbcn Apr 2, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise indentation! :)

</body>
</html>