Update content errors - #820
Draft
axlewin wants to merge 5 commits into
Draft
Conversation
If two title-less questions on the same page are given the same ID, the content flattener cannot distinguish between them so only one copy is in the Set of flattened content that is checked for duplicate IDs. By giving the questions distinct titles, both questions are included in the flattened content Set and the duplicate ID content error is applied.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
=======================================
Coverage 41.00% 41.00%
=======================================
Files 550 550
Lines 23602 23606 +4
Branches 2848 2850 +2
=======================================
+ Hits 9678 9680 +2
- Misses 13052 13054 +2
Partials 872 872 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new content error for questions that are not marked "exact answer only" but don't have sig fig bounds set (the behaviour here is to default to 2 sig figs, but this is not made obvious to content developers).
Fix an issue where the duplicate ID content error was not applied to questions on the same page that had the same title (including no title).