Skip to content

Signup overhaul: 11-12, SSO - #2262

Open
jacbn wants to merge 32 commits into
mainfrom
feature/ada-signup-11-to-12
Open

Signup overhaul: 11-12, SSO#2262
jacbn wants to merge 32 commits into
mainfrom
feature/ada-signup-11-to-12

Conversation

@jacbn

@jacbn jacbn commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
  • Allows 11-12 users to log in to Ada via SSO.
  • Reworks the SSO flow to direct back into the email signup flow, such that required account info is not left to the RAI modal after signing up.
  • As a consequence, allows teachers to sign up directly on Ada with SSO, like they can for email
  • Adjusts Ada user info collection to:
    • include required DoB, MM/YY only
    • require gender input
    • remove defaults for (non-assignment) email prefs; require users to pick values for news + events options
  • Shifts user preferences before "Account created!" message (Ada)
  • Adds "Account created!" message for Sci with graphic, to align the two flows more closely

Comment thread src/app/services/validation.ts Fixed
@jacbn jacbn changed the title Signup overhaul: 11-14, SSO Signup overhaul: 11-12, SSO Jul 23, 2026
jacbn and others added 5 commits July 23, 2026 15:47
The checkbox size is now aligned across both sites, so we can remove the exception we had for the top margin to align with the first line of text.
…to-12

[VRT] Update baselines for feature/ada-signup-11-to-12
@jacbn
jacbn marked this pull request as ready for review July 23, 2026 15:27
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.98883% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.20%. Comparing base (5e8f71b) to head (e3528ed).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
...rc/app/components/pages/RegistrationSetDetails.tsx 2.94% 33 Missing ⚠️
...p/components/pages/RegistrationAgeCheckSSOOnly.tsx 41.37% 17 Missing ⚠️
src/app/state/actions/index.tsx 8.33% 11 Missing ⚠️
...pp/components/handlers/ProviderCallbackHandler.tsx 11.11% 8 Missing ⚠️
.../app/components/elements/sidebar/SignupSidebar.tsx 12.50% 7 Missing ⚠️
src/app/components/pages/RegistrationAgeCheck.tsx 12.50% 7 Missing ⚠️
...rc/app/components/pages/RegistrationRoleSelect.tsx 16.66% 5 Missing ⚠️
...components/elements/inputs/TrueFalseRadioInput.tsx 55.55% 4 Missing ⚠️
src/app/components/pages/RegistrationSuccess.tsx 42.85% 4 Missing ⚠️
src/app/components/elements/inputs/DobInput.tsx 50.00% 2 Missing and 1 partial ⚠️
... and 7 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2262   +/-   ##
=======================================
  Coverage   43.20%   43.20%           
=======================================
  Files         601      602    +1     
  Lines       25757    25806   +49     
  Branches     8574     8616   +42     
=======================================
+ Hits        11128    11150   +22     
- Misses      14580    14597   +17     
- Partials       49       59   +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/app/components/pages/RegistrationAgeCheck.tsx Outdated
Comment thread src/app/components/elements/sidebar/SignupSidebar.tsx Outdated
Comment thread src/app/components/pages/RegistrationAgeCheckSSOOnly.tsx
Comment thread src/app/components/pages/RegistrationAgeCheck.tsx
Comment thread src/app/components/pages/MyAccount.tsx
Comment thread src/app/services/validation.ts Outdated
Comment thread src/app/components/elements/inputs/DobInput.tsx Outdated
actions-user and others added 3 commits July 30, 2026 14:20
…to-12

[VRT] Update baselines for feature/ada-signup-11-to-12
For all signup flow text and validation, use new `SITE_LOWER_AGE_LIMIT` and parental constent equivalent to ensure consistency across the site
Comment thread src/app/components/elements/inputs/DobInput.tsx Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants