fix: remove invalid unicode escapes from regExpEscape#289
Open
abhu85 wants to merge 1 commit intoisaacs:mainfrom
Open
fix: remove invalid unicode escapes from regExpEscape#289abhu85 wants to merge 1 commit intoisaacs:mainfrom
abhu85 wants to merge 1 commit intoisaacs:mainfrom
Conversation
Characters like comma, hash, hyphen, and whitespace were being escaped
with backslash in the regExpEscape function. However, these escape
sequences (e.g., \,) are invalid in unicode regex mode (/u flag).
When a pattern includes a POSIX character class like [[:space:]], the
unicode flag is required because POSIX classes use unicode property
escapes (e.g., \p{Z}). This caused patterns like ",[[:space:]]" to
throw a SyntaxError.
The fix removes these unnecessary escapes from regExpEscape. These
characters don't need escaping outside of character classes since they
are not regex metacharacters.
Fixes isaacs#273
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #273 - Invalid regex generated when glob includes comma and character class.
The
regExpEscapefunction was escaping characters like,,#,-, and whitespace with backslash (e.g.,\,). However, these escape sequences are invalid in unicode regex mode (/uflag).When a pattern includes a POSIX character class like
[[:space:]], the unicode flag is required because POSIX classes use unicode property escapes (e.g.,\p{Z}). This caused patterns like,[[:space:]]to throw:Changes
Modified
regExpEscapeinsrc/ast.tsto only escape characters that are both:Added comprehensive test suite in
test/posix-class-with-comma.jscovering:Test Plan
minimatch('foo', ',[[:space:]]')threw SyntaxErrorGenerated with Claude Code