This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Add expiry configuration setting to exclude old messages#23
Open
NateRobinsonS wants to merge 2 commits into
Open
Add expiry configuration setting to exclude old messages#23NateRobinsonS wants to merge 2 commits into
expiry configuration setting to exclude old messages#23NateRobinsonS wants to merge 2 commits into
Conversation
Update manifest.json to require jsonpath package (isabellaalstrom#21)
Added an "expiry" setting in the config file. Messages that are older than this setting will be excluded from the sensor. Note: I was unable to make this an optional setting. I suspect that the cv.time_period_dict type cannot be optional. This makes the proposed upgrade a breaking change!
Owner
|
I want to try this out before merging, due to the breaking change. I will do that as soon as I have the time. |
Contributor
Author
|
I strongly agree, and there's no rush. I only have one system to test on.
I won't take it personally if you choose not to use it. :)
…-Nate
On Mon, Apr 6, 2020 at 9:54 AM Isabella Gross Alström < ***@***.***> wrote:
I want to try this out before merging, due to the breaking change. I will
do that as soon as I have the time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7XJUBSA2OBMH6APNJZXR3RLGDEZANCNFSM4LWOHHMA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an
expirysetting in the config file to allow older messages to be dropped from the sensor after a configureable amount of time. Messages from krisinformation's API that are older than this setting will be excluded from the sensor.Note: I was unable to make this an optional setting in the configuration file. Omitting the "expiry" setting causes the
config_checkto fail. I suspect that thecv.time_period_dicttype cannot be optional. As a result, the proposed upgrade is a breaking change!Example configuration: