Dashboard: add PerfectGas to recompression model and shrink chart markers#66
Merged
Conversation
dyreby
force-pushed
the
add-perfectgas-to-recomp-dashboard
branch
from
b527d8f to
44f45c6
Compare
dyreby
changed the title
dyreby
force-pushed
the
add-perfectgas-to-recomp-dashboard
branch
from
44f45c6 to
24edbb9
Compare
The recompression model dropdown only listed CoolProp, even though the Rust facade already handles PerfectGas. Add the missing option. Also fix the doc comment on RecompDesignPointInput.model — it claimed PerfectGas would fail for recomp_frac > 0, but the solver works fine. The real limitation is that ideal gas won't capture the thermodynamic benefit of recompression (no density asymmetry near the critical point).
Reduce circle radius from 9 to 5 and label font from 9px to 7px. Numbers stay readable but overlap less on dense diagrams.
dyreby
force-pushed
the
add-perfectgas-to-recomp-dashboard
branch
from
24edbb9 to
c9738e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small dashboard improvements:
PerfectGas model for recompression cycle: The model dropdown only listed CoolProp, even though the Rust facade already handles PerfectGas. Added the missing option. Also fixed the doc comment on
RecompDesignPointInput.model— it claimed PerfectGas would fail forrecomp_frac > 0, but the solver works fine. The real limitation is that ideal gas won't show the thermodynamic benefit of recompression (no density asymmetry near the critical point).Smaller state point markers on cycle charts: Reduced circle radius from 9 to 5 and label font from 9px to 7px. The numbers stay readable but overlap less on dense diagrams (especially the 10-point recompression cycle).