Bump twine-models to 0.4#67
Merged
Merged
Conversation
Remove Effectiveness type and fields from solution structs. twine-models 0.4 drops built-in effectiveness from recuperator outputs; brayton already computes it independently via pinch-point analysis (added in #65).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
twine-modelsfrom 0.3 to 0.4.The only breaking change is the removal of
Effectivenessfrom recuperator output structs. This is a clean removal — brayton already computes effectiveness independently via pinch-point analysis (#65), so the fields on the internal solution structs were unused downstream.Changes:
Cargo.toml/Cargo.lock: version bumpsimple::Solution: removerecuperator_effectiveness: Effectivenessfieldrecompression::Solution: removelt_effectivenessandht_effectivenessfields.effectivenessfrom recuperator results