support non-adiabatic tank insulation#66
Merged
dyreby merged 3 commits intoMar 5, 2026
Conversation
Signed-off-by: mbodmer <marc.bodmer@email.ch>
Signed-off-by: mbodmer <marc.bodmer@email.ch>
- Use type-safe uom multiplication (U * Area) instead of raw .value extraction - Use ThermalConductance::ZERO for adiabatic case - Fix terminology: overall heat transfer coefficient, not thermal transmittance - Trim docs to match existing style (no # Arguments sections) - Remove redundant Insulation::adiabatic() constructor - Hoist imports to module scope - Add #[must_use] on constructors (clippy pedantic)
Contributor
|
Thanks for this, @mbodmer. Non-adiabatic insulation is something we knew we'd need to add eventually, and your implementation and test coverage are solid. We don't have a CONTRIBUTING guide yet (this project is still young and moving quickly), so you had no way to know our conventions. That's on me, sorry! I pushed a conventions cleanup commit on top of yours (b125a67). Mostly terminology, naming, and doc style to match the rest of the codebase. The physics and expected values from your PR are unchanged. Thanks again, really appreciate the contribution. |
This was referenced Mar 5, 2026
Contributor
Author
|
Thanks for the review and merge. I had expected you to clean it up, so this is great. Glad to support this nice project of yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.