adds reusable work flow on dev for generating config map#33
Merged
Sahil-STFC merged 2 commits intoJun 11, 2026
Merged
Conversation
dmbrownless
reviewed
Jun 10, 2026
Comment on lines
+19
to
+20
| description: > | ||
| The key under which the file content appears in ConfigMap .data. |
Contributor
There was a problem hiding this comment.
Not sure why only this one is folded but I guess it doesn't matter.
Contributor
There was a problem hiding this comment.
some descriptions use single quotes, some use double quotes
I guess couldn't hurt to make the formatting more consistent?
JonFijalkowski
approved these changes
Jun 10, 2026
dmbrownless
approved these changes
Jun 10, 2026
Ziggiyzoo
reviewed
Jun 10, 2026
| jobs: | ||
| generate-configmap:: | ||
| name: Generate & Commit ConfigMap | ||
| runs-on: ${{ inputs.runner_label }} |
Contributor
There was a problem hiding this comment.
I still think we should use GitHubs public runners. And use the azure/setup-kubetcl / install kubectl as part of the workflow.
However we have kubectl on the self hosted runners now so it will work.
Comment on lines
+111
to
+113
| echo "ConfigMap name : ${CM}" | ||
| echo "Namespace : ${NS}" | ||
| echo "Data key : ${KEY}" |
Contributor
There was a problem hiding this comment.
Not sure if this is GH displaying it oddly, but this looks like it is being interpreted differently to the rest of the run: | block..
Sahil-STFC
deleted the
#32-Create-reusable-workflows-for-generating-configmaps
branch
Sahil-STFC
restored the
#32-Create-reusable-workflows-for-generating-configmaps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #32