Fix explicit setting of timelimit #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the explicit modifications of the hpc join step to insert submit options. This works better than defining host-specific options as it allows the usage of any previous submit options already in the suite and not potentially dropping suite host-specific required options. Furthermore, now after the step is fully parsed and set then we can ensure our forced in situ modifications do not get overwritten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the explicit modifications of the hpc join step to insert submit options. This works better than defining host-specific options as it allows the usage of any previous submit options already in the suite and not potentially dropping suite host-specific required options. Furthermore, now after the step is fully parsed and set then we can ensure our forced in situ modifications do not get overwritten.