Skip to content

test: Add various unit tests - #317

Merged
itachi1706 merged 1 commit into
masterfrom
add-tests
Apr 2, 2026
Merged

test: Add various unit tests#317
itachi1706 merged 1 commit into
masterfrom
add-tests

Conversation

@itachi1706

@itachi1706 itachi1706 commented Apr 2, 2026

Copy link
Copy Markdown
Owner

No description provided.

@itachi1706 itachi1706 self-assigned this Apr 2, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 2, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request expands the test suite for the helperlib module by adding unit tests for ApiException, LogHelper, ValidationHelper, ApiResponse, and HttpRequest, alongside enhancements to the android.util.Log mock and CoroutineAsyncTask tests. The review feedback identifies an incorrect exception expectation in the JSON decoding tests and highlights a potential lifecycle bug in CoroutineAsyncTask where cancellation triggers after task completion. Additionally, it is recommended to replace non-deterministic delays in asynchronous tests with standard coroutine testing utilities to improve reliability.

Comment thread helperlib/src/test/java/com/itachi1706/helperlib/objects/ApiResponseTest.kt
Comment thread helperlib/src/test/java/com/itachi1706/helperlib/concurrent/CoroutineAsyncTaskTest.kt
Comment thread helperlib/src/test/java/com/itachi1706/helperlib/concurrent/CoroutineAsyncTaskTest.kt
@sonarqubecloud

sonarqubecloud Bot commented Apr 2, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@itachi1706
itachi1706 enabled auto-merge April 2, 2026 05:01
@itachi1706
itachi1706 merged commit 676b66e into master Apr 2, 2026
8 checks passed
@itachi1706
itachi1706 deleted the add-tests branch April 2, 2026 05:01
@itachi1706 itachi1706 linked an issue Apr 2, 2026 that may be closed by this pull request
Unit Tests #191
Closed
@itachi1706 itachi1706 mentioned this pull request Apr 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@itachi1706 itachi1706

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unit Tests

1 participant

@itachi1706