Skip to content

hardcoded server/runner port names #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nick-Andreano merged 2 commits into from
Jan 7, 2026
Merged

hardcoded server/runner port names #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd6c21b
hardcoded ports
Nick-Andreano Jan 6, 2026
3b53986
updated version in pipeline
Nick-Andreano Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/helm-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
- name: Set up Helm
uses: azure/setup-helm@v3
with:
version: v3.13.3
version: v3.15.0

- name: Install helm-unittest plugin
run: helm plugin install https://github.com/helm-unittest/helm-unittest
run: helm plugin install https://github.com/helm-unittest/helm-unittest --version v1.0.0

- name: Lint Helm chart
run: helm lint charts/iag5
Expand Down
2 changes: 1 addition & 1 deletion charts/iag5/templates/deployment-runner.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ spec:
image: "{{ $.Values.image.repository }}:{{ $.Values.image.tag | default $.Chart.AppVersion }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
ports:
- name: {{ include "iag5.fullname" $ }}-runner
- name: runner-port
containerPort: {{ $.Values.port }}
protocol: TCP
{{- if $.Values.livenessProbe.enabled }}
Expand Down
2 changes: 1 addition & 1 deletion charts/iag5/templates/deployment-server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- name: {{ include "iag5.fullname" . }}-server
- name: server-port
containerPort: {{ .Values.port }}
protocol: TCP
{{- if .Values.livenessProbe.enabled }}
Expand Down
2 changes: 1 addition & 1 deletion charts/iag5/tests/deployment-runner_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ tests:
asserts:
- equal:
path: spec.template.spec.containers[0].ports[0].name
value: RELEASE-NAME-iag5-runner
value: runner-port
- equal:
path: spec.template.spec.containers[0].ports[0].containerPort
value: 8080
Expand Down
2 changes: 1 addition & 1 deletion charts/iag5/tests/deployment-server_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ tests:
asserts:
- equal:
path: spec.template.spec.containers[0].ports[0].name
value: RELEASE-NAME-iag5-server
value: server-port
- equal:
path: spec.template.spec.containers[0].ports[0].containerPort
value: 8080
Expand Down