Corrected restart adapter cmd to stop then start adapter#166
Merged
Corrected restart adapter cmd to stop then start adapter#166
Conversation
privateip
requested changes
Nov 5, 2025
Member
privateip
left a comment
privateip
left a comment
There was a problem hiding this comment.
I think the runner should call https://github.com/itential/ipctl/blob/devel/pkg/services/adapters.go#L230 instead of this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart adapter function was only stopping the adapter, not starting it. Code now stops the adapter, ignoring any errors because it could already be stopped. It then starts the adapter.