Skip to content

Add feature flag support for dataset commands #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
privateip merged 1 commit into from
Mar 18, 2025
Merged

Add feature flag support for dataset commands #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ const description = `Manage Itential Platform

func loadCommands(cmd *cobra.Command, h handlers.Handler, cfg *config.Config) {
addCommandGroup(cmd, h, "Asset Commands:", assetCommands)
addCommandGroup(cmd, h, "Dataset Commands:", datasetCommands)
if cfg.FeaturesDatasetsEnabled {
addCommandGroup(cmd, h, "Dataset Commands:", datasetCommands)
}
addCommandGroup(cmd, h, "Platform Commands:", platformCommands)
addCommandGroup(cmd, h, "Plugin Commands:", pluginCommands)
}
Expand Down
10 changes: 10 additions & 0 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ const (
defaultAppDefaultProfile = ""
defaultAppDefaultRepository = ""

defaultFeaturesDatasetsEnabled = false

defaultLogLevel = "INFO"
defaultLogFileJson = false
defaultLogConsoleJson = false
Expand All @@ -43,6 +45,8 @@ type Config struct {
DefaultProfile string `json:"default_profile"`
DefaultRepository string `json:"default_repository"`

FeaturesDatasetsEnabled bool `json:"datasets_enabled"`

// Profiles
profileName string
profiles map[string]*Profile
Expand Down Expand Up @@ -182,6 +186,8 @@ func (ac *Config) populateFields() {
ac.DefaultProfile = viper.GetString("application.default_profile")
ac.DefaultRepository = viper.GetString("application.default_repository")

ac.FeaturesDatasetsEnabled = viper.GetBool("features.datasets_enabled")

ac.LogLevel = viper.GetString("log.level")
ac.LogFileJSON = viper.GetBool("log.file_json")
ac.LogConsoleJSON = viper.GetBool("log.console_json")
Expand All @@ -201,6 +207,8 @@ var defaultValues = map[string]interface{}{
"application.default_profile": defaultAppDefaultProfile,
"application.default_repository": defaultAppDefaultRepository,

"features.datasets_enabled": defaultFeaturesDatasetsEnabled,

"log.level": defaultLogLevel,
"log.file_json": defaultLogFileJson,
"log.console_json": defaultLogConsoleJson,
Expand All @@ -220,6 +228,8 @@ var defaultEnvVarBindings = map[string]string{
"application.default_profile": "IPCTL_APPLICATION_DEFAULT_PROFILE",
"application.default_repository": "IPCTL_APPLICATION_DEFAULT_REPOSITORY",

"features.datasets_enabled": "IPCTL_FEATURES_DATASETS_ENABLED",

"log.level": "IPCTL_LOG_LEVEL",
"log.file_json": "IPCTL_LOG_FILE_JSON",
"log.console_json": "IPCTL_LOG_CONSOLE_JSON",
Expand Down
Loading