Skip to content

The import role ... command fails with --replace on initial import #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
privateip merged 1 commit into from
Mar 29, 2025
Merged

The import role ... command fails with --replace on initial import #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions internal/runners/roles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ func (r *RoleRunner) Get(in Request) (*Response, error) {

}

// Describe implements the `describe role ...` command
func (r *RoleRunner) Describe(in Request) (*Response, error) {
logger.Trace()

Expand Down Expand Up @@ -99,8 +100,13 @@ func (r *RoleRunner) Describe(in Request) (*Response, error) {
return nil, errors.New(fmt.Sprintf("role `%s` does not exist", in.Args[0]))
}

var output = []string{
fmt.Sprintf("Name: %s (%s), Type: %s", role.Name, role.Id, role.Provenance),
fmt.Sprintf("Description: %s", role.Description),
}

return NewResponse(
"",
strings.Join(output, "\n"),
WithObject(role),
), nil
}
Expand Down Expand Up @@ -278,10 +284,14 @@ func (r *RoleRunner) Import(in Request) (*Response, error) {
if common.Replace {
existing, err := GetByName(r.service, role.Name)
if err != nil {
return nil, err
if !strings.HasSuffix(err.Error(), "does not exist") {
return nil, err
}
}
if err := r.service.Delete(existing.Id); err != nil {
return nil, err
if existing != nil {
if err := r.service.Delete(existing.Id); err != nil {
return nil, err
}
}
}

Expand Down