Closed
Conversation
Add --config to the call CLI subcommand so configuration files can be specified directly (e.g., itential-mcp call get_health --config file.conf). This brings parity with the run and test commands which already support it. Also fix a pre-existing argparse issue where --config placed before the subcommand (e.g., itential-mcp --config file.conf call ...) was silently overwritten by the subparser default. The parser now pre-captures --config from raw args and restores it if the subparser clobbered the value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The call command assumed tool results were always JSON, causing a JSONDecodeError when the server was configured with response_format=toon. Now gracefully handles non-JSON responses by printing them directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
privateip
added a commit
to privateip/itential-mcp
that referenced
this pull request
Feb 25, 2026
- Use json_utils.loads() for safer JSON parsing with error handling - Fall back to plain text output when JSON parsing fails - Add comprehensive test coverage for JSON parsing scenarios - Handle malformed JSON, empty strings, HTML responses gracefully This change supercedes itential#311
Member
|
Closing this PR. Fix was provided in #316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toon response format support in call output
The fix in runner.py is simple: try json.loads first, if it fails (toon or any other format), print the text directly. 2217
tests passing.