Skip to content

Fix/run service keyword arg#312

Closed
AutomateIP wants to merge 3 commits intoitential:develfrom
AutomateIP:fix/run_service_keyword_arg
Closed

Fix/run service keyword arg#312
AutomateIP wants to merge 3 commits intoitential:develfrom
AutomateIP:fix/run_service_keyword_arg

Conversation

@AutomateIP
Copy link
Contributor

  • Source fix: tools/gateway_manager.py:159 — changed run_service(name, cluster, input_params) to run_service(name, cluster,
    input_params=input_params)
    • Test fix: Updated 5 assert_called_once_with assertions in test_tools_gateway_manager.py to match the keyword argument pattern

joksan.flores and others added 3 commits February 13, 2026 12:39
Add --config to the call CLI subcommand so configuration files can be
specified directly (e.g., itential-mcp call get_health --config file.conf).
This brings parity with the run and test commands which already support it.

Also fix a pre-existing argparse issue where --config placed before the
subcommand (e.g., itential-mcp --config file.conf call ...) was silently
overwritten by the subparser default. The parser now pre-captures --config
from raw args and restores it if the subparser clobbered the value.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The call command assumed tool results were always JSON, causing a
JSONDecodeError when the server was configured with response_format=toon.
Now gracefully handles non-JSON responses by printing them directly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The platform service method gateway_manager.run_service() declares
input_params as keyword-only (after *), but the tool was passing it
positionally, causing "takes 3 positional arguments but 4 were given".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AutomateIP AutomateIP requested a review from a team as a code owner February 13, 2026 18:04
@privateip
Copy link
Member

Fixed in #317. closing this PR

@privateip privateip closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants